[codex] fix: remove shadowed _generated_sibling_path overload breaking smoke test#1
Draft
markoblogo wants to merge 1 commit into
Draft
[codex] fix: remove shadowed _generated_sibling_path overload breaking smoke test#1markoblogo wants to merge 1 commit into
markoblogo wants to merge 1 commit into
Conversation
…test The feat(status) commit added a second _generated_sibling_path(path, generated_suffix) definition that shadowed the original single-argument version. The call site in _handle_file still used the old one-argument form, causing: _generated_sibling_path() missing 1 required positional argument: 'generated_suffix' Fix: remove the now-dead first definition and update the call to pass the default '.generated' suffix, preserving identical behaviour for AGENTS.md and RUNBOOK.md. Co-Authored-By: Oz <oz-agent@warp.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
feat(status)commit (36d0b93) introduced a new_generated_sibling_path(path, generated_suffix)function at the bottom ofactions.pyfor the newstatuscommand. However, a legacy_generated_sibling_path(path)definition (single argument, no suffix) already existed earlier in the same file.Python resolved this to the last definition, so when
_handle_filecalled_generated_sibling_path(path)(single-arg form) it hit the new two-arg signature — causing:Both Python 3.11 and 3.12 CI jobs failed on
test3_no_markers_creates_generated_files.Root cause
Duplicate function definition: the old one-arg version at line 245 was silently shadowed by the new two-arg version added for the
statuscommand.Fix
_generated_sibling_pathdefinition (lines 245–250)._handle_file(line 208) to pass".generated"as the suffix, matching the previous default behaviour exactly (AGENTS.md→AGENTS.generated.md,RUNBOOK.md→RUNBOOK.generated.md).Verification
All three smoke tests pass locally:
Run:
python -m agentsgen._smoke