Skip to content

Update engine to Node 14.x #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
maxfontani wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Update engine to Node 14.x #49

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6e3e9b1
Update to work with Node 14
maxfontani Feb 26, 2021
9c9f9e9
Add module suport in Node 14
maxfontani Feb 26, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,10 @@
{
"name": "heroku-cra-node",
"version": "3.0.0",
"type": "module",
"description": "How to use create-react-app with a custom Node API on Heroku",
"engines": {
"node": "10.x"
"node": "14.x"
},
"scripts": {
"start": "node server",
Expand Down
3 changes: 3 additions & 0 deletions server/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,9 @@ const path = require('path');
const cluster = require('cluster');
const numCPUs = require('os').cpus().length;

const __filename = fileURLToPath(import.meta.url)
const __dirname = path.dirname(__filename)

const isDev = process.env.NODE_ENV !== 'production';
const PORT = process.env.PORT || 5000;

Expand Down