Fix FaultTest line numbers after SPDX header shift#21
Open
Ekats wants to merge 1 commit into
Open
Conversation
Commit 7113bb4 added 2 SPDX lines to FaultApplet.java but did not bump FaultTest's line refs. The IFEQ for `if (branch != 0)` moved from line 62 to 64, so the flip no longer fires and testFault returned 0x6f00 instead of 0x9000. The second ref (line 24) pointed at `foo = (byte[]) tmp;` — no conditional jump for the interceptor to flip, no-op even before the shift. Removed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Commit 7113bb4 (
Switch license headers to SPDX/REUSE) added 2 SPDX lines to the top of every file, includingFaultApplet.java, but didn't bump the line refs inFaultTest. The IFEQ forif (branch != 0)moved from line 62 to 64, so the flip no longer fires andtestFaultreturned0x6f00instead of0x9000.The second ref (line 24) pointed at
foo = (byte[]) tmp;— no conditional jump for the interceptor to flip, so it was a no-op even before the shift. Removed.Test plan
./mvnw -pl simulator test -Dtest=FaultTest—testFaultandtestNoFaultboth pass./mvnw clean install— 218 tests, 0 failures, 0 errors