Skip to content

Conversation

@Gowiem
Copy link
Member

@Gowiem Gowiem commented Dec 12, 2025

what

  • Adds a redirect of /tying-knot/ => /tying-the-masterpoint-knot/

why

  • The tool (linktree) where I created our QR Code that we're sharing alongside the pieces of rope that we're sending out doesn't have the ability to edit my old link... it's just gone. Not great. Won't continue to use that tool for sure.

references

  • Not cool:
CleanShot 2025-12-12 at 15 04 26

Summary by CodeRabbit

Release Notes

  • Chores
    • Updated URL routing to redirect "/tying-knot/" to "/tying-the-masterpoint-knot/" for improved content navigation.
    • Enhanced error page handling with explicit status code configuration for better HTTP compliance.

✏️ Tip: You can customize this high-level summary in your review settings.

@Gowiem Gowiem self-assigned this Dec 12, 2025
@Gowiem Gowiem requested a review from a team as a code owner December 12, 2025 22:04
@netlify
Copy link

netlify bot commented Dec 12, 2025

Deploy Preview for masterpoint ready!

Name Link
🔨 Latest commit 7df9161
🔍 Latest deploy log https://app.netlify.com/projects/masterpoint/deploys/693c917a982ff900080a5248
😎 Deploy Preview https://deploy-preview-95--masterpoint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 27
Accessibility: 86
Best Practices: 92
SEO: 79
PWA: 70
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 12, 2025

Walkthrough

Adds a permanent redirect from "/tying-knot/" to "/tying-the-masterpoint-knot/" with 301 status and force enabled. Also explicitly specifies 404 status code for the existing catch-all redirect to "/404.html".

Changes

Cohort / File(s) Change Summary
Netlify Redirect Configuration
netlify.toml
Adds new permanent redirect (301) from "/tying-knot/" to "/tying-the-masterpoint-knot/" with force enabled. Updates catch-all redirect to "/404.html" to explicitly include 404 status code.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

Suggested reviewers

  • gberenice
  • oycyc

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: adding a redirect for a QR code endpoint from /tying-knot/ to /tying-the-masterpoint-knot/.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feature/add-redirect-from-qrcode-link

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
netlify.toml (1)

41-46: Cover both trailing-slash and no-trailing-slash variants for /tying-knot

Right now the rule matches /tying-knot/ specifically; if anything hits /tying-knot (no trailing slash), it may bypass this rule and fall through to the catch-all 404. I’d add a second redirect to be safe.

 [[redirects]]
 from = "/tying-knot/"
 to = "/tying-the-masterpoint-knot/"
 status = 301
 force = true
+
+[[redirects]]
+from = "/tying-knot"
+to = "/tying-the-masterpoint-knot/"
+status = 301
+force = true

Based on learnings / coding guidelines (redirects belong in netlify.toml).

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 47ed529 and 7df9161.

📒 Files selected for processing (1)
  • netlify.toml (1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
netlify.toml

📄 CodeRabbit inference engine (CLAUDE.md)

Define redirects in netlify.toml (e.g., /updates/* → /blog/*)

Files:

  • netlify.toml
🧠 Learnings (2)
📓 Common learnings
Learnt from: CR
Repo: masterpointio/masterpoint.io PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-09-19T19:21:07.260Z
Learning: Applies to netlify.toml : Define redirects in netlify.toml (e.g., /updates/* → /blog/*)
📚 Learning: 2025-09-19T19:21:07.260Z
Learnt from: CR
Repo: masterpointio/masterpoint.io PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-09-19T19:21:07.260Z
Learning: Applies to netlify.toml : Define redirects in netlify.toml (e.g., /updates/* → /blog/*)

Applied to files:

  • netlify.toml
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
  • GitHub Check: Redirect rules - masterpoint
  • GitHub Check: Header rules - masterpoint
  • GitHub Check: Pages changed - masterpoint
🔇 Additional comments (1)
netlify.toml (1)

48-51: Explicit status = 404 on the catch-all is the right behavior
Serving /404.html with a real 404 status avoids “soft 404s” and is better for SEO and client behavior.

@Gowiem Gowiem merged commit 52a7ba2 into master Dec 12, 2025
9 checks passed
@Gowiem Gowiem deleted the feature/add-redirect-from-qrcode-link branch December 12, 2025 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants