-
Notifications
You must be signed in to change notification settings - Fork 1
feat: adds a redirect for where our QR Code points to #95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for masterpoint ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
WalkthroughAdds a permanent redirect from "/tying-knot/" to "/tying-the-masterpoint-knot/" with 301 status and force enabled. Also explicitly specifies 404 status code for the existing catch-all redirect to "/404.html". Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Suggested reviewers
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
netlify.toml (1)
41-46: Cover both trailing-slash and no-trailing-slash variants for/tying-knotRight now the rule matches
/tying-knot/specifically; if anything hits/tying-knot(no trailing slash), it may bypass this rule and fall through to the catch-all 404. I’d add a second redirect to be safe.[[redirects]] from = "/tying-knot/" to = "/tying-the-masterpoint-knot/" status = 301 force = true + +[[redirects]] +from = "/tying-knot" +to = "/tying-the-masterpoint-knot/" +status = 301 +force = trueBased on learnings / coding guidelines (redirects belong in
netlify.toml).
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
netlify.toml(1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
netlify.toml
📄 CodeRabbit inference engine (CLAUDE.md)
Define redirects in netlify.toml (e.g., /updates/* → /blog/*)
Files:
netlify.toml
🧠 Learnings (2)
📓 Common learnings
Learnt from: CR
Repo: masterpointio/masterpoint.io PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-09-19T19:21:07.260Z
Learning: Applies to netlify.toml : Define redirects in netlify.toml (e.g., /updates/* → /blog/*)
📚 Learning: 2025-09-19T19:21:07.260Z
Learnt from: CR
Repo: masterpointio/masterpoint.io PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-09-19T19:21:07.260Z
Learning: Applies to netlify.toml : Define redirects in netlify.toml (e.g., /updates/* → /blog/*)
Applied to files:
netlify.toml
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
- GitHub Check: Redirect rules - masterpoint
- GitHub Check: Header rules - masterpoint
- GitHub Check: Pages changed - masterpoint
🔇 Additional comments (1)
netlify.toml (1)
48-51: Explicitstatus = 404on the catch-all is the right behavior
Serving/404.htmlwith a real 404 status avoids “soft 404s” and is better for SEO and client behavior.

what
/tying-knot/=>/tying-the-masterpoint-knot/why
references
Summary by CodeRabbit
Release Notes
✏️ Tip: You can customize this high-level summary in your review settings.