Skip to content

Conversation

@oycyc
Copy link
Contributor

@oycyc oycyc commented Dec 26, 2025

There's only 10 lines of code diff. trunk fmt linting updated lots of whitespace, so you can hide whitespace in the PR review to see a cleaner diff.

  • Currently, when the /now content was implemented and for the team members bio to use that, it got rid of the usage of the bio: field.
    • So for those that don't have a /now content, even the original bio: content doesn't show. See example below.
image image
  • Additionally, it now also displays BOTH bio: AND the /now content.
    • Currently / previously existing, it only displayed the /now content so the actual bio was missing.
image

Summary by CodeRabbit

  • Refactor

    • Reorganized team member layout and moved popup content to a dedicated block for clearer structure.
    • Consolidated conditional logic for displaying bios and social links to ensure consistent rendering.
  • Content

    • Updated a team member designation from "Owner" to "CEO + CTO".
  • Style

    • Improved formatting and indentation of team member presentation.

✏️ Tip: You can customize this high-level summary in your review settings.

@oycyc oycyc requested a review from a team as a code owner December 26, 2025 13:53
@netlify
Copy link

netlify bot commented Dec 26, 2025

Deploy Preview for masterpoint ready!

Name Link
🔨 Latest commit 0fef6c8
🔍 Latest deploy log https://app.netlify.com/projects/masterpoint/deploys/694ec6ac33c2840008788072
😎 Deploy Preview https://deploy-preview-96--masterpoint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 27
Accessibility: 86
Best Practices: 92
SEO: 79
PWA: 70
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 26, 2025

Walkthrough

Rewrote the Hugo team shortcode (layouts/shortcodes/team.html) to loop and structure team member rendering, move and separate popup markup, and add conditional gating for bio and content based on the "NO UPDATE" sentinel; updated front matter for content/team/matt-gowie.md (designation change).

Changes

Cohort / File(s) Summary
Team shortcode template refactor
layouts/shortcodes/team.html
Replaced flat member rendering with a looped structure; moved popup markup outside the main item into a dedicated popup block; always renders image/title/designation in popup; added conditional gating to render bio and main content only when present and not equal to "NO UPDATE"; consolidated LinkedIn/GitHub/social conditionals and adjusted HTML nesting/closures.
Team content front-matter update
content/team/matt-gowie.md
Updated front-matter designation from Owner to CEO + CTO; removed a commented GitHub line.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

Suggested reviewers

  • Gowiem
  • gberenice
  • rttomlinson

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: introducing bio text display in team member popups, which aligns with the layout restructuring and bio/gating logic introduced in the changeset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feat/who-we-are-bio-text

📜 Recent review details

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0038f8c and 0fef6c8.

📒 Files selected for processing (1)
  • content/team/matt-gowie.md
🧰 Additional context used
📓 Path-based instructions (2)
content/**/*.md

📄 CodeRabbit inference engine (CLAUDE.md)

content/**/*.md: Place all site content in Markdown files under /content/
Use absolute URLs in content (paths should start with "/", e.g., /blog/ not blog/)
Reference images in content using the /img/ path (which maps to /static/img/)
Use front matter draft: true to hide in-progress content from production
Use provided Hugo shortcodes (button, buttonout, form, testimonials, faqs, team, services, process, supports, client-logos) in content instead of duplicating HTML

Files:

  • content/team/matt-gowie.md
content/team/*.md

📄 CodeRabbit inference engine (CLAUDE.md)

Team member pages are Markdown files in content/team/ named firstname-lastname.md

Files:

  • content/team/matt-gowie.md
🧠 Learnings (1)
📓 Common learnings
Learnt from: CR
Repo: masterpointio/masterpoint.io PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-09-19T19:21:07.260Z
Learning: Applies to content/team/*.md : Team member pages are Markdown files in content/team/ named firstname-lastname.md
Learnt from: oycyc
Repo: masterpointio/masterpoint.io PR: 68
File: layouts/partials/head.html:0-0
Timestamp: 2025-07-02T01:48:08.985Z
Learning: In the masterpointio/masterpoint.io Hugo project, the user oycyc prefers to maintain consistency with existing code patterns rather than making isolated optimizations, even when technically better approaches are available. They prioritize consistency over over-optimization.
🔇 Additional comments (1)
content/team/matt-gowie.md (1)

3-3: Designation update is accurate and consistent.

The change from "Owner" to "CEO + CTO" aligns with the bio text on line 9, which explicitly states Matt is "the CEO + CTO of Masterpoint." This improves clarity on the team member card while maintaining consistency across the front matter and bio content.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@oycyc oycyc force-pushed the feat/who-we-are-bio-text branch from baf4df5 to 3a7c012 Compare December 26, 2025 13:54
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 52a7ba2 and 3a7c012.

📒 Files selected for processing (1)
  • layouts/shortcodes/team.html
🧰 Additional context used
🧠 Learnings (2)
📓 Common learnings
Learnt from: CR
Repo: masterpointio/masterpoint.io PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-09-19T19:21:07.260Z
Learning: Applies to content/team/*.md : Team member pages are Markdown files in content/team/ named firstname-lastname.md
Learnt from: CR
Repo: masterpointio/masterpoint.io PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-09-19T19:21:07.260Z
Learning: Applies to content/**/*.md : Use provided Hugo shortcodes (button, buttonout, form, testimonials, faqs, team, services, process, supports, client-logos) in content instead of duplicating HTML
Learnt from: oycyc
Repo: masterpointio/masterpoint.io PR: 68
File: layouts/partials/head.html:0-0
Timestamp: 2025-07-02T01:48:08.985Z
Learning: In the masterpointio/masterpoint.io Hugo project, the user oycyc prefers to maintain consistency with existing code patterns rather than making isolated optimizations, even when technically better approaches are available. They prioritize consistency over over-optimization.
📚 Learning: 2025-09-19T19:21:07.260Z
Learnt from: CR
Repo: masterpointio/masterpoint.io PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-09-19T19:21:07.260Z
Learning: Applies to content/team/*.md : Team member pages are Markdown files in content/team/ named firstname-lastname.md

Applied to files:

  • layouts/shortcodes/team.html
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (6)
  • GitHub Check: Trunk Check
  • GitHub Check: lint
  • GitHub Check: Trunk Check
  • GitHub Check: Redirect rules - masterpoint
  • GitHub Check: Header rules - masterpoint
  • GitHub Check: Pages changed - masterpoint
🔇 Additional comments (1)
layouts/shortcodes/team.html (1)

20-20: Whitespace cleanup looks good.

Minor formatting improvement with no functional impact.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

♻️ Duplicate comments (1)
layouts/shortcodes/team.html (1)

50-62: Bio and content rendering logic is correct for the PR objective.

The implementation properly shows:

  1. The bio paragraph when it exists
  2. An HR separator only when bio exists AND content is valid
  3. The /now content independently when it's not "NO UPDATE"

The fragile "NO UPDATE" string matching concern was already addressed in a previous review comment.

🧹 Nitpick comments (1)
layouts/shortcodes/team.html (1)

28-40: Consider adding rel="noopener noreferrer" to external links.

External links with target="_blank" are safer with rel="noopener noreferrer" to prevent reverse tabnapping. However, this applies to the existing pattern throughout the file, so it could be addressed in a separate cleanup if desired.

📜 Review details

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3a7c012 and 0038f8c.

📒 Files selected for processing (1)
  • layouts/shortcodes/team.html
🧰 Additional context used
🧠 Learnings (2)
📓 Common learnings
Learnt from: CR
Repo: masterpointio/masterpoint.io PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-09-19T19:21:07.260Z
Learning: Applies to content/team/*.md : Team member pages are Markdown files in content/team/ named firstname-lastname.md
Learnt from: CR
Repo: masterpointio/masterpoint.io PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-09-19T19:21:07.260Z
Learning: Applies to content/**/*.md : Use provided Hugo shortcodes (button, buttonout, form, testimonials, faqs, team, services, process, supports, client-logos) in content instead of duplicating HTML
Learnt from: oycyc
Repo: masterpointio/masterpoint.io PR: 68
File: layouts/partials/head.html:0-0
Timestamp: 2025-07-02T01:48:08.985Z
Learning: In the masterpointio/masterpoint.io Hugo project, the user oycyc prefers to maintain consistency with existing code patterns rather than making isolated optimizations, even when technically better approaches are available. They prioritize consistency over over-optimization.
📚 Learning: 2025-09-19T19:21:07.260Z
Learnt from: CR
Repo: masterpointio/masterpoint.io PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-09-19T19:21:07.260Z
Learning: Applies to content/team/*.md : Team member pages are Markdown files in content/team/ named firstname-lastname.md

Applied to files:

  • layouts/shortcodes/team.html
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
  • GitHub Check: Redirect rules - masterpoint
  • GitHub Check: Header rules - masterpoint
  • GitHub Check: Pages changed - masterpoint
🔇 Additional comments (2)
layouts/shortcodes/team.html (2)

1-4: LGTM!

The loop correctly filters team pages and orders by weight parameter.


5-26: LGTM!

The team card properly renders image with fallback, member details, and popup trigger button.

---
title: Matt Gowie
designation: Owner
designation: CEO + CTO
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Gowiem I think you prefer to go by this title, which was the way it was before the website rework. Just noticed it and updated it here, feel free to lmk to revert if otherwise

Copy link
Member

@Gowiem Gowiem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff @oycyc -- Thanks!

@oycyc oycyc merged commit b39ec0f into master Dec 26, 2025
9 checks passed
@oycyc oycyc deleted the feat/who-we-are-bio-text branch December 26, 2025 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants