-
Notifications
You must be signed in to change notification settings - Fork 1
feat: show bio text in team member popups #96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for masterpoint ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
WalkthroughRewrote the Hugo team shortcode ( Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested reviewers
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: Repository UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🧰 Additional context used📓 Path-based instructions (2)content/**/*.md📄 CodeRabbit inference engine (CLAUDE.md)
Files:
content/team/*.md📄 CodeRabbit inference engine (CLAUDE.md)
Files:
🧠 Learnings (1)📓 Common learnings🔇 Additional comments (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
baf4df5 to
3a7c012
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
layouts/shortcodes/team.html
🧰 Additional context used
🧠 Learnings (2)
📓 Common learnings
Learnt from: CR
Repo: masterpointio/masterpoint.io PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-09-19T19:21:07.260Z
Learning: Applies to content/team/*.md : Team member pages are Markdown files in content/team/ named firstname-lastname.md
Learnt from: CR
Repo: masterpointio/masterpoint.io PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-09-19T19:21:07.260Z
Learning: Applies to content/**/*.md : Use provided Hugo shortcodes (button, buttonout, form, testimonials, faqs, team, services, process, supports, client-logos) in content instead of duplicating HTML
Learnt from: oycyc
Repo: masterpointio/masterpoint.io PR: 68
File: layouts/partials/head.html:0-0
Timestamp: 2025-07-02T01:48:08.985Z
Learning: In the masterpointio/masterpoint.io Hugo project, the user oycyc prefers to maintain consistency with existing code patterns rather than making isolated optimizations, even when technically better approaches are available. They prioritize consistency over over-optimization.
📚 Learning: 2025-09-19T19:21:07.260Z
Learnt from: CR
Repo: masterpointio/masterpoint.io PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-09-19T19:21:07.260Z
Learning: Applies to content/team/*.md : Team member pages are Markdown files in content/team/ named firstname-lastname.md
Applied to files:
layouts/shortcodes/team.html
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (6)
- GitHub Check: Trunk Check
- GitHub Check: lint
- GitHub Check: Trunk Check
- GitHub Check: Redirect rules - masterpoint
- GitHub Check: Header rules - masterpoint
- GitHub Check: Pages changed - masterpoint
🔇 Additional comments (1)
layouts/shortcodes/team.html (1)
20-20: Whitespace cleanup looks good.Minor formatting improvement with no functional impact.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
♻️ Duplicate comments (1)
layouts/shortcodes/team.html (1)
50-62: Bio and content rendering logic is correct for the PR objective.The implementation properly shows:
- The bio paragraph when it exists
- An HR separator only when bio exists AND content is valid
- The
/nowcontent independently when it's not "NO UPDATE"The fragile "NO UPDATE" string matching concern was already addressed in a previous review comment.
🧹 Nitpick comments (1)
layouts/shortcodes/team.html (1)
28-40: Consider addingrel="noopener noreferrer"to external links.External links with
target="_blank"are safer withrel="noopener noreferrer"to prevent reverse tabnapping. However, this applies to the existing pattern throughout the file, so it could be addressed in a separate cleanup if desired.
📜 Review details
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
layouts/shortcodes/team.html
🧰 Additional context used
🧠 Learnings (2)
📓 Common learnings
Learnt from: CR
Repo: masterpointio/masterpoint.io PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-09-19T19:21:07.260Z
Learning: Applies to content/team/*.md : Team member pages are Markdown files in content/team/ named firstname-lastname.md
Learnt from: CR
Repo: masterpointio/masterpoint.io PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-09-19T19:21:07.260Z
Learning: Applies to content/**/*.md : Use provided Hugo shortcodes (button, buttonout, form, testimonials, faqs, team, services, process, supports, client-logos) in content instead of duplicating HTML
Learnt from: oycyc
Repo: masterpointio/masterpoint.io PR: 68
File: layouts/partials/head.html:0-0
Timestamp: 2025-07-02T01:48:08.985Z
Learning: In the masterpointio/masterpoint.io Hugo project, the user oycyc prefers to maintain consistency with existing code patterns rather than making isolated optimizations, even when technically better approaches are available. They prioritize consistency over over-optimization.
📚 Learning: 2025-09-19T19:21:07.260Z
Learnt from: CR
Repo: masterpointio/masterpoint.io PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-09-19T19:21:07.260Z
Learning: Applies to content/team/*.md : Team member pages are Markdown files in content/team/ named firstname-lastname.md
Applied to files:
layouts/shortcodes/team.html
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
- GitHub Check: Redirect rules - masterpoint
- GitHub Check: Header rules - masterpoint
- GitHub Check: Pages changed - masterpoint
🔇 Additional comments (2)
layouts/shortcodes/team.html (2)
1-4: LGTM!The loop correctly filters team pages and orders by weight parameter.
5-26: LGTM!The team card properly renders image with fallback, member details, and popup trigger button.
| --- | ||
| title: Matt Gowie | ||
| designation: Owner | ||
| designation: CEO + CTO |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Gowiem I think you prefer to go by this title, which was the way it was before the website rework. Just noticed it and updated it here, feel free to lmk to revert if otherwise
Gowiem
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good stuff @oycyc -- Thanks!

/nowcontent was implemented and for the team members bio to use that, it got rid of the usage of thebio:field./nowcontent, even the originalbio:content doesn't show. See example below.bio:AND the/nowcontent./nowcontent so the actual bio was missing.Summary by CodeRabbit
Refactor
Content
Style
✏️ Tip: You can customize this high-level summary in your review settings.