solution#1839
Conversation
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
I am requesting changes because there are a few critical requirement mismatches that block full task completion. First, the people data is hardcoded in main.js instead of being imported from people.json, which violates the requirement to use the provided JSON data source [CHECKLIST ITEM #5]; you should replace the inline array with an import/usage of the JSON file as described in the task. Second, the demo link still contains the <your_account> placeholder instead of your actual GitHub username [CHECKLIST ITEM #1], so the deployment link requirement is not met—update the README or description to use your real account name. Third, you modified other files (README.md, workflow template) in addition to main.js, which goes against the constraint to change only main.js for this task [CHECKLIST ITEM #7]; please revert non-essential changes so only main.js is altered. On the positive side, your table-generation logic in main.js is correct: you create rows with six cells, compute age as died - born, compute century with Math.ceil(died / 100), and append rows to the .dashboard table body as required. Once you fix the data source, demo link, and extra file changes, your solution will fully meet the task standards.
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Important
Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.
Tip
If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.
Caution
Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.
No description provided.