Skip to content

parce list#2008

Open
Tendeeer wants to merge 1 commit into
mate-academy:masterfrom
Tendeeer:develop
Open

parce list#2008
Tendeeer wants to merge 1 commit into
mate-academy:masterfrom
Tendeeer:develop

Conversation

@Tendeeer

Copy link
Copy Markdown
- [DEMO LINK](https://Tendeeer.github.io/js_task_parse_list_DOM/)

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

I am approving your solution because it correctly implements all the core functional requirements of the task. Your sortList(list) function locates the <ul> list, parses the data-salary values via a dedicated parseSalary helper, and sorts the <li> elements in descending order by numeric salary before re-appending them to the list, which fulfills the sorting requirement. The getEmployees(list) function builds an array of employee objects with the exact required schema { name, position, salary, age }, converting salary and age to numbers, so the data extraction requirement is also met. Both functions are invoked, so the behavior is actually executed rather than just defined.

One small improvement for your own debugging and verification is to consider using or logging the result of getEmployees(list), so you can quickly confirm the produced array at runtime. Overall, the code is clear, focused on the requirements, and doesn’t introduce unnecessary complexity—well done on meeting the task’s expectations.


✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨

Footnotes

  1. Rate AI review example

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants