add task solution#2016
Conversation
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Your solution is approved because it correctly implements all the core functional requirements in main.js. You retrieve the list from the DOM using document.querySelector('ul'), implement sortList to sort items by numeric salary in descending order using the data-salary attribute, and append the sorted items back to the list, which will produce the expected visual result. You also implement getEmployees to return an array of employee objects with the required schema { name, position, salary, age }, correctly reading from dataset and converting salary and age to numbers. Both functions are invoked as required, so there are no critical blockers or missing functionality for this task.
One minor improvement (not required for acceptance) is that the result of getEmployees(list) is currently unused; you could store it in a variable if later logic or debugging needs it. Also remember that updating the demo link with your GitHub username is done outside main.js, in the README or description, if that is part of your course checklist. Overall, you met the task requirements well—nice work.
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
No description provided.