Skip to content

add task solution#2016

Open
Vlad99M wants to merge 1 commit into
mate-academy:masterfrom
Vlad99M:develop
Open

add task solution#2016
Vlad99M wants to merge 1 commit into
mate-academy:masterfrom
Vlad99M:develop

Conversation

@Vlad99M

@Vlad99M Vlad99M commented Jun 28, 2026

Copy link
Copy Markdown

No description provided.

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

Your solution is approved because it correctly implements all the core functional requirements in main.js. You retrieve the list from the DOM using document.querySelector('ul'), implement sortList to sort items by numeric salary in descending order using the data-salary attribute, and append the sorted items back to the list, which will produce the expected visual result. You also implement getEmployees to return an array of employee objects with the required schema { name, position, salary, age }, correctly reading from dataset and converting salary and age to numbers. Both functions are invoked as required, so there are no critical blockers or missing functionality for this task.

One minor improvement (not required for acceptance) is that the result of getEmployees(list) is currently unused; you could store it in a variable if later logic or debugging needs it. Also remember that updating the demo link with your GitHub username is done outside main.js, in the README or description, if that is part of your course checklist. Overall, you met the task requirements well—nice work.


✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨

Footnotes

  1. Rate AI review example

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants