Updated plugin file writing to use NSString.writeToFile_atomically#3
Open
chriscohoat wants to merge 3 commits into
Open
Updated plugin file writing to use NSString.writeToFile_atomically#3chriscohoat wants to merge 3 commits into
chriscohoat wants to merge 3 commits into
Conversation
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The line:
Was giving me an an error. You can reproduce with something like the following:
My changes are the only way I can seem to get the SVG to write to my filesystem. I also added a helper method to save the file along-side the original SVG, which people may want if they want to retain the original version of the SVG.
Sketch version 55 and I'm on macOS Catalina (Version 10.15.3).