Update CDN API class default base_url #33
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Hey @vp-regular, |
Contributor
|
or probably we should take the URL as a param from the user, and have a default URL |
…lar/BunnyCDN-Python-Lib into feat/update-cdn-base-url
Contributor
Author
|
See 289a7b2. Does this repo not use black for formatting? It looks like the linting was already an issue and not part of the diff. I tested this URL change for
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like https://bunnycdn.com/api/billing was removed, as the endpoint returns 404's instead of 401 when no access key is provided. Current bunnycdn api documentation suggests the current production api endpoint was moved to https://api.bunny.net/ ~two weeks ago. Overriding
base_urlmanually after creating aCDNobject seems to return correct billing data.I smoke tested a couple of the other methods via curl/browser and they seem to point to valid api endpoints, but I didn't test their corresponding methods in this library. This should probably be further tested before merging.