Skip to content
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 26 additions & 0 deletions Columns/Base.php
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,32 @@ public function onNewVisit(Request $request, Visitor $visitor, $action)
return null;
}

public function onExistingVisit(Request $request, Visitor $visitor, $action)
{
$campaignDetector = StaticContainer::get('advanced_campaign_reporting.campaign_detector');
$campaignParameters = MarketingCampaignsReporting::getCampaignParameters();

$campaignDimensions = $campaignDetector->detectCampaignFromRequest(
$request,
$campaignParameters
);

if ($this->isCurrentReferrerDirectEntry($visitor)
&& !empty($campaignDimensions)
&& array_key_exists($this->getColumnName(), $campaignDimensions)
) {
return substr($campaignDimensions[$this->getColumnName()], 0, $this->getColumnName() == 'campaign_id' ? 100 : 255);
}

return false;
}

protected function isCurrentReferrerDirectEntry(Visitor $visitor)
{
$referrerType = $visitor->getVisitorColumn('referer_type');
return $referrerType == Common::REFERRER_TYPE_DIRECT_ENTRY;
}

/**
* @param Request $request
* @param Visitor $visitor
Expand Down
1 change: 0 additions & 1 deletion stylesheets/styles.less
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
.visitorReferrer.campaign {
display: none; /* do not show default campaign information in visitor log */
}

.visitorCampaign {
Expand Down
18 changes: 18 additions & 0 deletions tests/Fixtures/TrackAdvancedCampaigns.php
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,7 @@ public function trackCampaignVisits($disablePlugin, $dateTime)
$this->trackSeventhVisit_withGoalConversion($t, $dateTime);
$this->trackEigthVisit_withEcommerceAbandonedCart($t, $dateTime);
$this->trackNinthVisit_withEcommerceOrder($t, $dateTime);
$this->trackTenthVisit_withCampaignInformationInSecondAction($t, $dateTime);
}

public function tearDown(): void
Expand Down Expand Up @@ -253,6 +254,23 @@ protected function trackNinthVisit_withEcommerceOrder($t, $dateTime)
self::checkResponse($t->doTrackEcommerceOrder('Ecommerce_ORDER_ID_' . $this->orderIndex++, '555'));
}

private function trackTenthVisit_withCampaignInformationInSecondAction(\MatomoTracker $t, $dateTime)
{
$this->getTestEnvironment()->overrideConfig('Tracker', 'create_new_visit_when_campaign_changes', '0');
$this->getTestEnvironment()->save();

$this->moveTimeForward($t, 12.0, $dateTime);
$t->setUrl('http://example.com/');
self::checkResponse($t->doTrackPageView('Viewing homepage without campaign, recorded as a visit from Campaign, but...'));

$this->moveTimeForward($t, 12.1, $dateTime);
$t->setUrl('http://example.com/sub/page?mtm_campaign=SHOULD_BE_NEW_VISIT2');
$t->setCustomTrackingParameter('abc', '1');
self::checkResponse($t->doTrackPageView('Second page view, with campaign, should overwrite referrer information from previous visit'));

$this->getTestEnvironment()->overrideConfig('Tracker', 'create_new_visit_when_campaign_changes', '1');
}

/**
* @param \MatomoTracker $t
* @param $hourOffset
Expand Down