This repository was archived by the owner on Apr 26, 2024. It is now read-only.
Avoid updating the same rows multiple times with simple_update_many_txn.#16609
Merged
Avoid updating the same rows multiple times with simple_update_many_txn.#16609
Conversation
DMRobertson
approved these changes
Nov 7, 2023
Contributor
DMRobertson
left a comment
DMRobertson
left a comment
There was a problem hiding this comment.
Looking forward to the universal 2x speedup. (/s)
More seriously: nice find.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right now when we use
simple_update_many_txn(orsimple_update_many) it appends the arguments twice meaning each row is found and updated twice.I noticed this while writing the tests in #16596.
Logic has existed since it was added in #12252.
This is used when:
set_device_id_for_pushersbackground update.