chore: sync public export#4
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1a5c2e6a70
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| try { | ||
| const pullRequest = (await apiClient(`${basePath}/pulls/${number}`)) as GitHubPullRequest; | ||
| const files = (await apiClient(`${basePath}/pulls/${number}/files`)) as GitHubPullFile[]; |
There was a problem hiding this comment.
For PRs touching more than 30 files, this single call only returns the first page: GitHub documents the List pull request files endpoint as paginated with a default of 30 files per page (https://docs.github.com/en/rest/pulls/pulls#list-pull-requests-files), and the API client does not follow Link/page parameters. The cache and summary will under-report changedFiles and omit paths agents need for risk/policy decisions; request all pages before mapping the file list.
Useful? React with 👍 / 👎.
|
|
||
| const runs = checkRuns.check_runs ?? []; | ||
| const passing = runs.filter((run) => run.conclusion === 'success').length; | ||
| const failing = runs.filter((run) => run.conclusion === 'failure' || run.conclusion === 'cancelled').length; |
There was a problem hiding this comment.
When a completed check run concludes timed_out or action_required, GitHub returns those as valid conclusion values (https://docs.github.com/en/rest/checks/runs), but this filter only treats failure and cancelled as failing. In that scenario pending is also 0, so a PR with a timed-out required check is summarized as unknown instead of failure, hiding a blocking check from agents using the context.
Useful? React with 👍 / 👎.
1 participant
Generated from the private Kernel source allowlist sync workflow.
Verification run by this workflow: