Remove frictionlessdata/repository@v2 from actions#3
Remove frictionlessdata/repository@v2 from actions#3gabrielbdornas wants to merge 1 commit intomaxfordham:fix-cifrom
Conversation
See frictionlessdata/frictionless-ci#58 Using poetry to install frictionless Run frictionless validate Create issue on failure using JasonEtco/create-an-issue@v2
|
Hi @gabrielbdornas - thanks so much for your help with this! I integrated the logic you described here: but I'm a big pixi user (rather than poetry) so used that instead. I'm still getting an issue with the action that creates an issue on fail... I guess I need to somehow pass the outcome of the frictionless validation to the message? |
|
closing this as the principle outlined by @gabrielbdornas was merged in #2 |
Use actions to create Issue on frictionless validate errors See maxfordham#3 (comment)
|
@jgunstone, my pleasure!
Look, it worked here. I just uncomment (gabrielbdornas@8831794) the step in the action and then, emulate an error in your data (gabrielbdornas@8831794). What pass the outcome of the frictionless validation to the massage is the This created the issue https://github.com/gabrielbdornas/uknzcb-eui-targets/issues/1in my forked repository. I did this way because I supposed you wanted to be notified only when something go wrong. But of course your use case could be different, and you can improve this logic. In any case, just let me know if you need more help to improve this logic in one or another way. |
2 participants
See frictionlessdata/frictionless-ci#58
@jgunstone, as I told you here, I'm not sure if the repo frictionless-ci is active.
Based on that, I didn't spend much time debugging the
actionserror1:My suggestion would be creating your own
actionsto install2 and runfrictionless validatecommand. If the validation fails, you could be notified. I used theJasonEtco/create-an-issue@v2actions to create issues on failures, but you could change this approach based on your needs. You could also remove it if your only concern is not allowing merges on PR with invalid data.Maybe the disadvantage of this approach is losing the pretty validation errors created by frictionless-ci, but I think done is better than perfect, isn't it!!!?
Let me know if you have questions or need further help before merging it.
Footnotes
I also run it locally using act and received an
inquirysimilar error:Cannot upload inquiry: Unable to get ACTIONS_RUNTIME_TOKEN env variable. ↩As I'm more comfortable using Poetry, this was the tool used to install and run
frictionlessinactionsenvironment. But this could be changed without losing the suggestion idea. ↩