Open
Conversation
…Introduce use of r53 namespace.
…: '--type A' will show all A-types including A aliases. '--type ALIAS' won't return results. Aliases can be post-filtered with e.g. '| grep -v ALIAS'
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Mike,
I've added a couple of Route53-specific functions that enhance r53 interactivity in the following ways:
I suggest the introduction of the
r53-namespace. This makes it clear to the end-user that Route53 is the service is being used. This aligns with other examples likerds-*andlambda-*and encourages a move towards consistent namespacing.It might be the case that
lib/domain-functionsadopts this approach as well e.g.domains()->r53-domains()I've left the existing
hosted-anddomain-functions alone to keep this from being a breaking change. In theory the code forhosted-zonesandhosted-zone-ns-recordscan be removed, with aliases implemented in a way to maintain backwards compatibility. For example, something like this:Could instead be:
The command reference update also lays out a few other enhancements that I've added.
This hypothetically also supersedes #252