Open
Conversation
firestack
requested review from
a team and
rudiejd
and removed request for
a team
rudiejd
reviewed
Feb 6, 2026
| %{ | ||
| "original": &Concentrate.Encoder.GTFSRealtimeHelpers.group/1, | ||
| "new": &Concentrate.Encoder.GTFSRealtimeHelpers.group_new/1 | ||
| #"enum": fn -> Concentrate.Merge.merge(Enum.flat_map(data, &elem(&1, 1))) end, |
Member
There was a problem hiding this comment.
lots of commented code. should we remove this?
Member
|
can we add a README with an explanation for how to run these benchmarks and an example of the output? I'm afraid that otherwise they will become an artifact |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
Asana Ticket: No Ticket
Related to: #392
This adds benchmarks that were supposed to be in Concentrate when Benchee was originally added.
https://mbta.slack.com/archives/C06D663HRRN/p1764878824668259