Skip to content

feat(ScheduleFinderLive): more prominent cancelled stops#3013

Open
thecristen wants to merge 6 commits intomainfrom
cbj/sf2.0/cancelled-row
Open

feat(ScheduleFinderLive): more prominent cancelled stops#3013
thecristen wants to merge 6 commits intomainfrom
cbj/sf2.0/cancelled-row

Conversation

@thecristen
Copy link
Collaborator

Scope

Asana Ticket: [SF/UD] All Modes: Cross out the stop name as well as the time in trip details if a stop is skipped or a trip is cancelled

This has a bonus feature of adding a small "x" marker on the skipped stop marker.

Implementation

This also fixes a bug I found that I'd missed in reviewing #3009 - sometimes alerts have nil direction, and we should not exclude those from this page.

I don't love the CSS controlling the positioning of the "x" marker, but it's no less hacky than the "T" marker showing the current stop, so, eh?

Screenshots

image

How to test

Look for (or create) an active alert involving a stop closure, and then find it in Schedule Finder 2.0!

@thecristen thecristen requested a review from a team as a code owner March 13, 2026 19:16
@thecristen thecristen requested a review from lvachon1 March 13, 2026 19:16
Copy link
Contributor

@lvachon1 lvachon1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing my bug, this looks great too!

@thecristen thecristen changed the title Cbj/sf2.0/cancelled row feat(ScheduleFinderLive): more prominent cancelled stops Mar 13, 2026
Copy link
Contributor

@joshlarson joshlarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks great!

I left a tiny code-style comment about variants. I think I do eventually want to pull the xmark into the <.lined_list_marker /> (and maybe give a similar treatment to the stop pin, though slightly different, because the stop pin is a decoration on top of the marker, rather than a whole different kind of marker), but IMO that can be done in this PR or as a follow-up.

attr :route, Route, required: true
attr :class, :string, default: ""
attr :stop_pin?, :boolean, default: false
attr :stop_cancelled?, :boolean, default: false
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Style nit: This feels like a new variant, not a separate attribute. That is, a lined_list_item isn't going to be both variant="mode" and stop_cancelled?=true.

As a variant, the xmark icon could then be lumped into the <.lined_list_marker />, and maybe centered explicitly, rather than through CSS magic values.


I won't pretend to be certain of this, but at very large font sizes, the xmark doesn't look vertically centered, and I wonder if that's because of the magic values?

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants