Open
Conversation
…ain of the "day" departs early tomorrow morning
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
Asana Ticket: 📅🔎 Add screenreader text for +1
When spoken aloud by a screen reading device "12:49AM plus one" sounds rather ambiguous. This work replaces the screen reader content for that section so it reads "12:49AM the next morning" which is much less ambiguous.
Implementation
Added alternative text for screen readers indicating that the last train of the service day actually departs early tomorrow morning.
Added aria attributes necessary to hide the existing +1 from screen readers, and hide the a11y text from graphical browsers
Screenshots
Graphical version (unchanged)
A11y version (notice "the next morning" instead of "+1")
How to test
Visit the new SF on any line that runs after midnight.
http://localhost:4001/departures/?route_id=Red&direction_id=0&stop_id=place-dwnxg
I like to use Aria DevTools to work with a11y layers.