feat(ScheduleFinderLive): remove departures immediately on selecting service#3017
Merged
thecristen merged 2 commits intomainfrom Mar 16, 2026
Merged
feat(ScheduleFinderLive): remove departures immediately on selecting service#3017thecristen merged 2 commits intomainfrom
thecristen merged 2 commits intomainfrom
Conversation
lvachon1
approved these changes
Mar 16, 2026
Contributor
lvachon1
left a comment
lvachon1
left a comment
There was a problem hiding this comment.
This works very well! Even when throttled to 3G I can only see the spinner for a few frames.
We might want to adjust the spinner a bit. At faster speeds the UI quickly flickers down and up as the it briefly appears.
Screen.Recording.2026-03-16.at.3.00.08.PM.mov
Anyway, just a trivial nit-pick, this is super fast!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
Asana Ticket: 📅🔎 Investigate why the loading state for Daily Schedule schedule-change takes so long to appear
Implementation
Selecting another set of schedules to display is not so slow any more. But I figured it could feel even faster if I activated the loading state before fetching the date for the newly selected service.
How to test
On any
/departurespage, pick another service! Let me know if it's slow!