Fix Tests & Add NullableReferenceType-Annotations#211
Open
TheConstructor wants to merge 1 commit intomcintyre321:masterfrom
Open
Fix Tests & Add NullableReferenceType-Annotations#211TheConstructor wants to merge 1 commit intomcintyre321:masterfrom
TheConstructor wants to merge 1 commit intomcintyre321:masterfrom
Conversation
TheConstructor
force-pushed
the
feature/nrt
branch
4 times, most recently
from
f2f9a48 to
ee290c9
Compare
Also upgrade dependencies to have a none-failing build
TheConstructor
force-pushed
the
feature/nrt
branch
from
ee290c9 to
71e53b6
Compare
|
Thank you so much for your work. I bow before you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addresses #198 and probably includes the intended changes by #199 and #190.
I tried to only include the minimal changes to support Nullable Reference Type-annotations, which are available since .NET Core 2.1/.NET Standard 2.1, but ended up updating dependencies and synchronising the targets of
OneOfandOneOf.Extendedto get rid of build-time warning of known security vulnerabilities. I updated the target-framework from .NET 6 to .NET 9 for the same reason. .NET 9 seems to be the most recent version your appveyor-pipeline supports; I would have preferred .NET 10 as latest LTS-version