fix: use text/javascript MIME type for local-config.js endpoint#178
Merged
neonwatty merged 2 commits intoMay 19, 2026
Merged
Conversation
neonwatty
approved these changes
May 19, 2026
Collaborator
neonwatty
left a comment
There was a problem hiding this comment.
Reviewed with three independent sub-agents. Added deterministic route coverage for the local-config fallback/pass-through behavior; CI and local E2E are green.
|
🎉 This PR is included in version 1.37.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Collaborator
|
Thanks for fixing this @AntoineDeveloppeur ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
** Description of problem
After following the self-hosting setup steps, one of the E2E tests fails.
The issue is caused by this command:
cp public/test/local-config.example.js public/test/local-config.js
Screenshot of failed test:

The failure happens because MIME type of js file is 'text/javascript' the test needs 'application/javascript'
When test is run again if fails because the copied file contains text, but the test expects the file to be empty (line 65)
** Fix
All tests pass
No documentation update is needed