Split large model files across multiple buffers.#29
Open
jkinkead wants to merge 1 commit intomedallia:masterfrom
Open
Split large model files across multiple buffers.#29jkinkead wants to merge 1 commit intomedallia:masterfrom
jkinkead wants to merge 1 commit intomedallia:masterfrom
Conversation
Contributor
|
Ping? |
|
This fork breaks in the toBinFile method. vectors ( with the plural) is a DoubleBuffer[] and is unlikely to be as large as the vocab size. In most of my test cases, vectors is a DoubleBuffer array of length 1. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #28 by splitting large models into multiple buffers in memory.
Note on formatting: I used tabs throughout, as that seemed to be more common in the files.
SearcherImplwas mixed-use. I also tried to keep for-loop (for(vsfor () and naming similar to the local code. This was mixed-use as well.