Skip to content

fix incorrect vocabs when loading from utf-8 binary #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
thangntt2 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix incorrect vocabs when loading from utf-8 binary #38

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 10 additions & 5 deletions src/main/java/com/medallia/word2vec/Word2VecModel.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,19 +161,24 @@ public static Word2VecModel fromBinFile(File file, ByteOrder byteOrder, Profilin

long lastLogMessage = System.currentTimeMillis();
final float[] floats = new float[layerSize];

ByteBuffer bb = ByteBuffer.allocate(1000);
byte b;
for (int lineno = 0; lineno < vocabSize; lineno++) {
// read vocab
sb.setLength(0);
c = (char) buffer.get();
bb.rewind();
b = buffer.get();
c = (char)b;
while (c != ' ') {
// ignore newlines in front of words (some binary files have newline,
// some don't)
if (c != '\n') {
sb.append(c);
bb.put(b);
}
c = (char) buffer.get();
b = buffer.get();
c = (char)b;
}
vocabs.add(sb.toString());
vocabs.add(new String(bb.array(), 0, bb.position(), Charset.forName("utf-8")));

// read vector
final FloatBuffer floatBuffer = buffer.asFloatBuffer();
Expand Down