Conversation
philbudne
approved these changes
Jun 10, 2025
Contributor
philbudne
left a comment
There was a problem hiding this comment.
I have no clue about github ci integrations, so looks OK to me!
I'm not a fan of whitespace changes (since it obscures who is to blame), BUT I also hate trailing whitespace, and the lines are trivial, so.... APPROVED!
Contributor
Author
|
FYI: the automated pre-commit hooks listing made all the whitespace changes automatically. Not sure how they got in there in the first place... maybe someone didn't have the hooks set up?: |
pgulley
approved these changes
Jun 10, 2025
Contributor
Author
|
I guess I'll merge and try it with a real tag 🤞🏽 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right now we can't do automated releases, because of the error described in #105 . The suggested fix is to upgrade to
actions/upload-artifact@v4.6.2. Curious that the bot didn't suggest this alongside the fix for download-artifact (#93).I gave the migration guide and it doesn't look like any of the breaking changes impact our usage, but this definitely needs another pair of eyes reading to verify: https://github.com/actions/upload-artifact/blob/main/docs/MIGRATION.md
Also is there any way to test this automation against just the test deploy server? Or do we have to just push a real tag and have it build a real release?