Fixing playlist behavior when track ends#226
Open
Bakual wants to merge 1 commit intomediaelement:masterfrom
Open
Fixing playlist behavior when track ends#226Bakual wants to merge 1 commit intomediaelement:masterfrom
Bakual wants to merge 1 commit intomediaelement:masterfrom
Conversation
Bakual
added a commit
to Bakual/SermonSpeaker
that referenced
this pull request
Aug 5, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should both fix the issues #225 and #223
Means it properly detects the end of the playlist (since the
currentPlaylistItemstarts with0) and it properly sets the Source-URL of the PlaylistItem, and not the whole object as new player source (same as it is done for prev/next buttons).