fix: keyboard controls for source-chooser.js#266
Open
crhallberg wants to merge 3 commits intomediaelement:masterfrom
Open
fix: keyboard controls for source-chooser.js#266crhallberg wants to merge 3 commits intomediaelement:masterfrom
crhallberg wants to merge 3 commits intomediaelement:masterfrom
Conversation
This commit contributes work done for the [Universal Viewer project](https://github.com/UniversalViewer/universalviewer) that fixes broken keyboard controls for the source chooser and also adds arrow key controls.
WCAG recommended over keydown.
Author
|
You can try out these improvements in this UniversalViewer demo. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit contributes work done for the Universal Viewer project that fixes broken keyboard controls for the source chooser and also adds arrow key controls.
Apologies for the whitespace fixes making this a little messier, but it does seem to normalize the tabs and spaces.