Skip to content

Handle exceptions during refresh_formats #1348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
tcely wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Handle exceptions during refresh_formats #1348

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2eb01a6
Handle exceptions during refresh_formats
tcely Dec 16, 2025
f0f26b0
Log the response that was unexpected
tcely Dec 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions tubesync/sync/models/media__tasks.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
from django.conf import settings
from django.utils import timezone
from django.utils.translation import gettext_lazy as _
from yt_dlp.utils import DownloadError
from ..choices import Val, SourceResolution
from ..utils import filter_response, write_text_file

Expand Down Expand Up @@ -167,9 +168,13 @@ def refresh_formats(self):
last_attempt = round((now - self.posix_epoch).total_seconds())
self.save_to_metadata(attempted_key, last_attempt)
self.skip = False
metadata = self.index_metadata()
if self.skip:
try:
metadata = self.index_metadata()
except DownloadError:
return (False, True, 'found no formats; trying again')
else:
if self.skip:
return (False, True, 'found no formats; trying again')

fmt_dict = defaultdict(str)
response = metadata
Expand Down
1 change: 1 addition & 0 deletions tubesync/sync/youtube.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -267,6 +267,7 @@ class NoDefaultValue: pass # a unique Singleton, that may be checked for later
raise YouTubeError(f'Failed (again) to extract_info for "{url}": {ee}') from ee
# validate the response is what we expected
if not _subscriber_only(response=response):
log.debug(f'get_media_info: response: {response}')
response = {}

if not response:
Expand Down