Run the token web server with deno
#1351
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- `tubesync-init` changed the permissions of `node` before us
- `npm` really likes to write to "${HOME}"
- use the correct way to run `typescript/tsc`
tcely
force-pushed
the
tcely-bgutil-ytdlp-pot-provider
branch
2 times, most recently
from
a5f783c to
ef312be
Compare
When `node` has no arguments, it uses a read-execute-print loop so copy that behavior. Only require that HOME must be set for shell, then let the cryptic error from `deno` handle a foolishly empty/null HOME variable.
tcely
force-pushed
the
tcely-bgutil-ytdlp-pot-provider
branch
from
47919b0 to
e6e24df
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tip
Start the server inside an already running container with:
Using
denofor node compatibility, we can run the POT web service inside the container.This adds hundreds of megabytes (~240 MB) in extra storage, so I don't want to bundle it for everyone.
The end goal is, that anyone who wants this configuration, would only need to add one file to the user bundle.
$ touch "${HOME}/empty"Add the following to your
docker runarguments:-v "${HOME}/empty:/etc/s6-overlay/s6-rc.d/user/contents.d/bgutil-ytdlp-pot-provider:ro"This is likely a win in the common case where you only have one TubeSync container.
It also plays nicely for anyone who wants to modify the
Dockerfileso that the extra files can live in the image once instead of the overlay of each container.On the other hand, if you have a pool of
bgutil-ytdlp-pot-providercontainers that all your TubeSync containers access over HTTP, then it is wasted space in the image with no benefit.