Skip to content

Used gendarme DoubleCheckLockingRule to avoid singleton problems #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
soneyworld wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Used gendarme DoubleCheckLockingRule to avoid singleton problems #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 14 additions & 11 deletions src/Global.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,22 +61,25 @@ public static class Global {
private const string interface_name = "org.freedesktop.Notifications";
private const string object_path = "/org/freedesktop/Notifications";

private static INotifications dbus_object = null;
private static volatile INotifications dbus_object = null;
private static object dbus_object_lock = new object ();

internal static INotifications DBusObject {
get {
if (dbus_object != null)
return dbus_object;
if (dbus_object == null) {
lock (dbus_object_lock) {
if (dbus_object == null) {
if (! Bus.Session.NameHasOwner (interface_name)) {
Bus.Session.StartServiceByName (interface_name);
}

lock (dbus_object_lock) {
if (! Bus.Session.NameHasOwner (interface_name))
Bus.Session.StartServiceByName (interface_name);

dbus_object = Bus.Session.GetObject<INotifications>
(interface_name, new ObjectPath (object_path));
return dbus_object;
dbus_object = Bus.Session.GetObject<INotifications>
(interface_name, new ObjectPath (object_path));
}
}
}

return dbus_object;
}
}

Expand All @@ -85,7 +88,7 @@ public static string[] Capabilities {
return DBusObject.Capabilities;
}
}

public static ServerInformation ServerInformation {
get {
return DBusObject.ServerInformation;
Expand Down