Skip to content

Comments

[WC-3216] Gallery paging and autoselect#2034

Open
iobuhov wants to merge 23 commits intomainfrom
3216/gallery-paging-and-autoselect
Open

[WC-3216] Gallery paging and autoselect#2034
iobuhov wants to merge 23 commits intomainfrom
3216/gallery-paging-and-autoselect

Conversation

@iobuhov
Copy link
Collaborator

@iobuhov iobuhov commented Jan 19, 2026

Pull request type

Refactoring (e.g. file rename, variable rename, etc.)

New feature (non-breaking change which adds functionality)


Description

Migrated features from data grid to gallery.

What should be covered while testing?

  • Auto select first item
  • Selection counter
  • Load more
  • Virtual scroll
  • Pagination
  • Custom pagination
  • Custom empty state

@iobuhov iobuhov requested a review from a team as a code owner January 19, 2026 14:11
@iobuhov iobuhov force-pushed the 3216/gallery-paging-and-autoselect branch 3 times, most recently from ee916ba to 719c753 Compare February 2, 2026 11:46
@iobuhov iobuhov force-pushed the 3216/gallery-paging-and-autoselect branch 2 times, most recently from 38cf8bc to db93377 Compare February 12, 2026 13:24
@iobuhov iobuhov force-pushed the 3216/gallery-paging-and-autoselect branch from b505371 to b16badb Compare February 18, 2026 13:52
r0b1n
r0b1n previously approved these changes Feb 18, 2026
@iobuhov iobuhov force-pushed the 3216/gallery-paging-and-autoselect branch from 10116e7 to f51bf41 Compare February 19, 2026 09:52

- We added new attributes and a drop zone for custom pagination.

- We added support for the auto-select feature in multi-selection mode.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In single mode as well

import { usePaginationConfig } from "../model/hooks/injection-hooks";
import { Pagination } from "./Pagination";

export const GalleryTobBarControls = observer(function GalleryTobBarControls(): ReactElement {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo( it needs to correct the filename and imports probably:

Suggested change
export const GalleryTobBarControls = observer(function GalleryTobBarControls(): ReactElement {
export const GalleryTopBarControls = observer(function GalleryTopBarControls(): ReactElement {

preview
/>
>
<Item key="selectable_DO_NOE_REMOVE!_ALWAYS_RENDER!" />
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo:

Suggested change
<Item key="selectable_DO_NOE_REMOVE!_ALWAYS_RENDER!" />
<Item key="selectable_DO_NOT_REMOVE!_ALWAYS_RENDER!" />

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How you spotted them?

@iobuhov iobuhov force-pushed the 3216/gallery-paging-and-autoselect branch from f51bf41 to 97db940 Compare February 20, 2026 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants