fix(nc34): replace removed OC\Server::getURLGenerator() with OCP\Server::get()#76
Merged
Merged
Conversation
…rver::getURLGenerator() OC\Server::getURLGenerator() wurde in Nextcloud 34 entfernt. Die Methode wurde an zwei Stellen direkt aufgerufen (templates/index.php fuer die Logged-in-Shell, templates/guest.php fuer die Gastgalerie), beide crashen mit "Call to undefined method" sobald die App auf NC 34 geladen wird. Ersetzt durch \OCP\Server::get(\OCP\IURLGenerator::class) — der unterstuetzte DI-Weg, der seit NC 25 verfuegbar ist und damit die gesamte Compatibility-Range (29-34) abdeckt. Closes #75
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
\OC::$server->getURLGenerator()(removed in Nextcloud 34) with the supported DI-based\OCP\Server::get(\OCP\IURLGenerator::class).templates/index.php(logged-in app shell) andtemplates/guest.php(guest gallery deep-link URL).Without this fix StarRate throws a fatal
Call to undefined method OC\Server::getURLGenerator()on Nextcloud 34, even thoughinfo.xmlalready declaresmax-version="34"— so the app was effectively unusable on the latest NC release.Backwards compatibility
\OCP\Server::get()is available since Nextcloud 25, so the fix covers the full supported range (NC 29–34).Closes #75
Thanks to @miaulalala for the report and the spot-on suggested fix.
Test plan
Call to undefined methodstarrate://server URL correctly