update workflow, fixed bug to create build distribution#145
update workflow, fixed bug to create build distribution#145
Conversation
|
|
Hi @adi-khot ! |
|
Hi @CassNot, the bug was in build command. Before we use "python -m build" which uses the setuptools.build_meta driven by pyproject.toml. It does not rely on setup.py. |
|
PR approved on my end. I am letting @mario-valdivia merge as he could be interested in this solution, following our discussion 2 weeks ago ! |
…AND replaced broad package discovery with constrained discovery
|
@adi-khot and @mario-valdivia , I brought a few changes as we had discussed:
Problem 2: pyproject.toml sets
I tested these changes on test pypi and the correct tagged version was built. However, no archive version is built anymore (only the wheel), I think it is because we have |
Summary
Related Issue
Type of change
Proposed changes
How to test / How to run
Screenshots / Logs (optional)
Performance considerations (optional)
Documentation
Checklist