-
Notifications
You must be signed in to change notification settings - Fork 266
Add iceberg-cpp wrap #2449
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Add iceberg-cpp wrap #2449
Conversation
releases.json
Outdated
| "iceberg-cpp": { | ||
| "dependency_names": [ | ||
| "iceberg", | ||
| "iceberg_rest", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Upstream it looks like this mistakenly calls meson.override_dependency('iceberg-rest', ...) so need to fix that before release
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think iceberg_rest is far from being finalized. Perhaps add it later?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No problem
3f82584 to
aa4b4cb
Compare
|
I can't reproduce the issue here nor did the meson issue tracker yield anything. The iceberg-cpp default arguments contains: project(
'iceberg',
'cpp',
version: '0.2.0',
license: 'Apache-2.0',
meson_version: '>=1.3.0',
default_options: [
'cpp_std=c++23,c++latest',
],
)When I run locally it appears to correctly pass |
|
I think the "multiple standard" issue is described upstream in mesonbuild/meson#15202 |
|
Please rebase to fix the CI failures. |
aa4b4cb to
e89fcb0
Compare
@wgtmac