-
Notifications
You must be signed in to change notification settings - Fork 54
Add ROCm/AMD GPU support for kernel generation and optimization #119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
andyluo7
wants to merge
10
commits into
meta-pytorch:main
Choose a base branch
from
andyluo7:add-rocm-support
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
0300c77
Add ROCm/AMD GPU support for kernel generation and optimization
c261c43
Fix ROCm E2E: restore deleted methods, add fallback analysis, fix roc…
seungrokj 9f5eb24
fix(rocm): resolve ruff lint errors and test_timeout_s mismatch
eemars e5465a1
style: fix ruff format for ROCm support files
andyluo7 644ead2
feat(rocm): Add amd.yaml config for OOTB testing
eemars 4fc0331
Address review: rename rocm→amd in strategies, add --strategy to conf…
eemars c2b02d7
Address ROCm review follow-ups
eemars 1eceb3c
Fix ROCm synthetic fallback reprofiling loop
eemars 262a622
Fix rocprofv3 PMC counter grouping for gfx942
eemars 24b227d
style: fix ruff format for optimization_orchestrator.py
eemars File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,39 @@ | ||
| # AMD platform config for MI300X | ||
| # | ||
| # Usage: | ||
| # python examples/run_opt_manager.py \ | ||
| # --kernel-dir examples/optimize_01_matvec \ | ||
| # --strategy amd | ||
| # --config examples/configs/amd.yaml | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We can actually remove teh --config arg, strategy will resolve it for us |
||
|
|
||
| strategy: beam_search | ||
| num_workers: 4 | ||
| strategy_config: | ||
| num_top_kernels: 2 | ||
| num_bottlenecks: 2 | ||
| openai_model: gpt-5 | ||
| high_reasoning_effort: true | ||
|
|
||
| # Worker configuration | ||
| benchmark_warmup: 25 | ||
| benchmark_repeat: 100 | ||
| divergence_threshold: 50.0 | ||
| target_platform: rocm | ||
| gpu_name: "AMD Instinct MI300X" | ||
|
|
||
| platform: | ||
| # Manager-level components | ||
| verifier: rocm | ||
| benchmarker: rocm | ||
| worker_runner: rocm | ||
| # Worker-level components | ||
| specs_provider: rocm | ||
| profiler: rocm | ||
| roofline_analyzer: rocm | ||
| bottleneck_analyzer: rocm | ||
| rag_prescriber: rocm | ||
|
|
||
| templates: | ||
| kernel_optimization: triton_kernel_agent/templates/kernel_optimization.j2 | ||
| reflexion_prompt: triton_kernel_agent/templates/reflexion_prompt.j2 | ||
| triton_guidelines: triton_kernel_agent/templates/triton_guidelines.j2 | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You actually flagged a typo in
nvidia.yamltoo (it's also supposed to be strategy)