Conversation
meta-cla
bot
added
the
CLA Signed
Jack-Khuu
approved these changes
Mar 18, 2026
kaiming-cheng
approved these changes
Mar 18, 2026
There was a problem hiding this comment.
Pull request overview
Updates the GB300 Q/K-norm benchmark documentation to include a roofline-style bandwidth view (Oink vs CuTeDSL) alongside the existing steady-state CUDA-graph replay latency tables.
Changes:
- Adds a new pre-generated GB300 BF16 Q/K-norm roofline SVG plot (Oink vs CuTeDSL baseline).
- Updates
oink/README.mdto explain the roofline (“useful-bandwidth”) view and embeds the new SVG. - Extends the README takeaways with an explicit roofline-based interpretation.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
oink/benchmarks/media/gb300_bf16_qk_norm_oink_vs_cutedsl_roofline.svg |
Adds the new roofline visualization asset for the GB300 Q/K-norm comparison. |
oink/README.md |
Documents and embeds the new roofline plot; clarifies interpretation vs latency medians. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
| one read + one write of the fused `[M, N]` tensor. This is the physically | ||
| meaningful view for comparing against the measured practical GB300 BF16 stream | ||
| roof, whereas the steady-state CUDA-graph replay medians below are better read | ||
| as a latency view. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc @paulius-meta