Skip to content

Ph 211/fix syncscan #212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
frwa-enpace merged 2 commits into from
Mar 25, 2026
Merged

Ph 211/fix syncscan #212

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
eadae8c
fix: controller now returns the image when doing sync scan
frwa-enpace Mar 25, 2026
9cf47ef
fix: controller now returns the image when doing sync scan
frwa-enpace Mar 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/build.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ on:
- 'PH-201/*'
- 'PH-205/*'
- 'PH-209/*'
- 'PH-211/*'
pull_request:
branches:
- main
Expand Down
6 changes: 0 additions & 6 deletions internal/controllers/pharosimagemetacontroller.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,9 +117,6 @@ func (pc *PharosImageMetaController) V1Get() (huma.Operation, func(ctx context.C
return nil, huma.Error500InternalServerError("Failed to retrieve Docker image: " + err.Error())
}
}
if value.IndexDigest == "" {
return nil, huma.Error404NotFound("Image with ImageId " + input.ImageId + " not found")
}
return &PharosImageMeta{
Body: value,
}, nil
Expand Down Expand Up @@ -235,9 +232,6 @@ func (pc *PharosImageMetaController) V1GetContexts() (huma.Operation, func(ctx c
return nil, huma.Error500InternalServerError("Failed to retrieve Docker image: " + err.Error())
}
}
if value.IndexDigest == "" {
return nil, huma.Error404NotFound("Image with ImageId " + input.ImageId + " not found")
}
var contextEntries = []model.ContextEntry{}
for _, contextRoot := range value.ContextRoots {
for _, context := range contextRoot.Contexts {
Expand Down
Loading