Skip to content

Add recording download functionality to HikCamera#114

Open
ptarjan wants to merge 1 commit intomezz64:masterfrom
ptarjan:claude/add-recording-download-L5oCa
Open

Add recording download functionality to HikCamera#114
ptarjan wants to merge 1 commit intomezz64:masterfrom
ptarjan:claude/add-recording-download-L5oCa

Conversation

@ptarjan
Copy link
Copy Markdown
Contributor

@ptarjan ptarjan commented Feb 3, 2026

Summary

  • Add download_recording() method for streaming downloads via ISAPI ContentMgmt/download endpoint
  • Add async_download_recording() method using aiohttp for async consumers
  • Support both file-stream and iterator modes for flexible usage patterns

Test plan

  • Verify XML payload is correctly constructed with playbackURI
  • Test streaming to file-like objects returns correct byte count
  • Test iterator mode returns chunks correctly
  • Verify HTTP errors are properly propagated
  • Test custom chunk_size parameter is respected

https://claude.ai/code/session_01N6RJBX4VbRTnukeerAxCHx

Add download_recording() for streaming downloads via the ISAPI
ContentMgmt/download endpoint, supporting both file-stream and
iterator modes. Also add async_download_recording() using aiohttp
for async consumers. Includes 5 new tests covering XML payload
construction, stream/iterator modes, error handling, and chunk size.

https://claude.ai/code/session_01N6RJBX4VbRTnukeerAxCHx
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants