Add ORIGIN and LOCALE to Currency trait, add tests for minor_unit_name, origin, locale#11
Merged
Merged
Conversation
…, origin, locale Agent-Logs-Url: https://github.com/mfirhas/currencylib/sessions/beb67adc-e2fd-4765-a591-2cb12c19a8b1 Co-authored-by: mfirhas <11944811+mfirhas@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
mfirhas
May 7, 2026 10:05
View session
mfirhas
reviewed
May 7, 2026
…ncy test functions Agent-Logs-Url: https://github.com/mfirhas/currencylib/sessions/7c6cc16a-ce38-4653-b3e1-1df64e98e00b Co-authored-by: mfirhas <11944811+mfirhas@users.noreply.github.com>
mfirhas
requested changes
May 7, 2026
…ith MINOR_UNIT_NAME, ORIGIN, LOCALE Agent-Logs-Url: https://github.com/mfirhas/currencylib/sessions/646315e8-4dcd-48fc-bd71-ece13e55f1b2 Co-authored-by: mfirhas <11944811+mfirhas@users.noreply.github.com>
mfirhas
approved these changes
May 7, 2026
Owner
|
@copilot edit Makefile on lcov command, move clean before mkdir |
Agent-Logs-Url: https://github.com/mfirhas/currencylib/sessions/0bd36351-bd27-4b38-b752-e15ec2a0a0ae Co-authored-by: mfirhas <11944811+mfirhas@users.noreply.github.com>
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the two remaining
Datastruct attributes (originandlocale) to theCurrencytrait, and adds tests forminor_unit_name,origin, andlocale.Changes
src/lib.rs: AddedORIGINandLOCALEconstants to theCurrencytrait with doc comments.build.rs: Updated the code generator to emitORIGINandLOCALEin each currency'simpl Currencyblock.src/iso_currencies_test.rs: Extended each existing per-currency test function with three additional assertions:MINOR_UNIT_NAME— verifies the minor unit name for the currencyORIGIN— verifies the country/region of originLOCALE— verifies the BCP 47 locale tagAll 183 tests pass.