Change Data attributes numeric and minor_unit to u16#15
Merged
Conversation
Agent-Logs-Url: https://github.com/mfirhas/currencylib/sessions/06330aa1-77e6-4c6a-bf1c-ae3ce49cf6fe Co-authored-by: mfirhas <11944811+mfirhas@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
mfirhas
May 8, 2026 04:14
View session
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Data.numericfield type from&'static strtou16Data.minor_unitfield type from&'static strtou16ISO_CURRENCY_DATAmap to use integer literals instead of string literalsu16values instead of string valuesAll 188 tests pass and coverage is maintained.