fix: add .unwrap() to rates.set() calls in doc examples (issue #180 fix 5)#183
Merged
Conversation
…ix 5) Agent-Logs-Url: https://github.com/mfirhas/moneylib/sessions/612f4015-6e6a-4431-82c1-9e38d4208f45 Co-authored-by: mfirhas <11944811+mfirhas@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
mfirhas
May 19, 2026 23:21
View session
mfirhas
approved these changes
May 19, 2026
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes No.5 from issue #180.
Problem
ExchangeRates::setreturnsResult<(), MoneyError>, but several doc examples called it without handling the result:This inconsistency (compared to the
setmethod's own doc example which correctly used.unwrap()) teaches users that theResultcan be silently discarded, hiding potentialOverflowErrors.Fix
Added
.unwrap()to allrates.set(...)calls in doc examples that previously ignored the returnedResult:Exchange::convertdoc example (lines 66–67)ExchangeRatesstruct-level doc example (lines 224–227)ExchangeRates::getdoc example (lines 413–417)ExchangeRates::get_pairdoc example (lines 434–438)Verification
make all— all 1502 tests pass, doc tests passmake lcov— coverage report generated successfully