Fix Foreach Step restoration status precedence#5
Conversation
Prioritize derived status from child items over stored parent status in `WorkflowState.restore`. If all items in a foreach step are successful, the step is treated as SUCCESS even if the DB record says RUNNING or PENDING. This prevents unnecessary re-execution or stalls when resuming workflows that crashed after completing all iterations but before updating the parent step. Added a regression test `tests/runner/foreach_restore.test.ts`.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Prioritize derived status from child items over stored parent status in `WorkflowState.restore`. If all items in a foreach step are successful, the step is treated as SUCCESS even if the DB record says RUNNING or PENDING. This prevents unnecessary re-execution or stalls when resuming workflows that crashed after completing all iterations but before updating the parent step. Added a regression test `tests/runner/foreach_restore.test.ts`.
|
Fix the linting Jules |
Linting issues fixed. |
Prioritize derived status from child items over stored parent status in `WorkflowState.restore`. If all items in a foreach step are successful, the step is treated as SUCCESS even if the DB record says RUNNING or PENDING. This prevents unnecessary re-execution or stalls when resuming workflows that crashed after completing all iterations but before updating the parent step. Added a regression test `tests/runner/foreach_restore.test.ts`.
1 participant
Implemented a fix in
src/runner/workflow-state.tsto check if all items of a foreach step are successful during state restoration. If so, the step status is upgraded toSUCCESSin memory, overriding anyRUNNINGorPENDINGstatus from the database. This ensures workflows can resume correctly from such states. Added a verification test.PR created automatically by Jules for task 5413483979200927558 started by @mhingston