Conversation
Closed
mhvk
force-pushed
the
asp
branch
2 times, most recently
from
782c0b1 to
4a62f5f
Compare
…w the primary header
Adjust tests to try both at least a little bit.
…etter. Also simplify ASPStreamReader initialization.
By defining invariant_pattern on header. Allows one to get rid of _last_header override.
Likely the sample file was not created quite right, with ipts1 and ipts2 not properly adjusted.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds on #263 to what should be close to complete support for ASP (reading and writing). Unfortunately, the sample file used before was almost certainly not adjusted correctly for a smaller frame size, so full tests cannot be done without a real data set to check things on.
To do
dspsr.ipts1andipts2to match reduced sample size.docs/asp/index.rst.new_format.rstto describe how format is added in more detail (addressing New format tutorial #236)