feat: Add Support for Secrets defined at other objects#120
Open
psuet wants to merge 1 commit into
Open
Conversation
psuet
changed the title
Owner
|
Hi @psuet, thanks for your PR. I have added two comments on the code. Please check them. |
miaow2
requested changes
Jun 13, 2026
psuet
force-pushed
the
secrets-precedence
branch
from
a494153 to
6f50f12
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right now this plugin only supports configuring secrets for each device seperately. This is not ideal in setups where the same credentials are used for a class of devices.
This pull request introduces a configurable and extensible mechanism for fetching secrets from related objects, allowing users to define the precedence order for where credentials are sourced (device, role, platform, etc.).
The plugin supports a
SECRETS_PRECEDENCEconfiguration option, letting users specify the order in which the device secrets and related object secrets are checked for credentials. The default configuration forSECRETS_PRECEDENCEis set to["device", "role", "platform"]