Skip to content

Freeze event-type ABI: internal constructors + consistent copy() (closes #15) #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mibrahimdev merged 1 commit into from
Jun 14, 2026
Merged

Freeze event-type ABI: internal constructors + consistent copy() (closes #15) #26

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 0 additions & 12 deletions sharingan-noop/api/sharingan-noop.api
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,4 @@
public final class dev/sharingan/BleEvent : dev/sharingan/SharinganEvent {
public fun <init> (Ljava/lang/String;JLdev/sharingan/BleOperation;Ljava/lang/String;Ljava/lang/String;Ljava/lang/String;Ljava/lang/String;Ljava/lang/Long;Ljava/lang/String;)V
public synthetic fun <init> (Ljava/lang/String;JLdev/sharingan/BleOperation;Ljava/lang/String;Ljava/lang/String;Ljava/lang/String;Ljava/lang/String;Ljava/lang/Long;Ljava/lang/String;ILkotlin/jvm/internal/DefaultConstructorMarker;)V
public final fun component1 ()Ljava/lang/String;
public final fun component2 ()J
public final fun component3 ()Ldev/sharingan/BleOperation;
Expand All @@ -10,8 +8,6 @@ public final class dev/sharingan/BleEvent : dev/sharingan/SharinganEvent {
public final fun component7 ()Ljava/lang/String;
public final fun component8 ()Ljava/lang/Long;
public final fun component9 ()Ljava/lang/String;
public final fun copy (Ljava/lang/String;JLdev/sharingan/BleOperation;Ljava/lang/String;Ljava/lang/String;Ljava/lang/String;Ljava/lang/String;Ljava/lang/Long;Ljava/lang/String;)Ldev/sharingan/BleEvent;
public static synthetic fun copy$default (Ldev/sharingan/BleEvent;Ljava/lang/String;JLdev/sharingan/BleOperation;Ljava/lang/String;Ljava/lang/String;Ljava/lang/String;Ljava/lang/String;Ljava/lang/Long;Ljava/lang/String;ILjava/lang/Object;)Ldev/sharingan/BleEvent;
public fun equals (Ljava/lang/Object;)Z
public final fun getCharacteristic ()Ljava/lang/String;
public final fun getDevice ()Ljava/lang/String;
Expand Down Expand Up @@ -59,8 +55,6 @@ public final class dev/sharingan/BleOperation : java/lang/Enum {
}

public final class dev/sharingan/HttpEvent : dev/sharingan/SharinganEvent {
public fun <init> (Ljava/lang/String;JLjava/lang/String;Ljava/lang/String;Ljava/lang/Integer;Ljava/lang/Long;Ljava/util/List;Ljava/util/List;Ljava/lang/String;Ljava/lang/String;Ljava/lang/String;Ljava/lang/Long;Ljava/util/List;Ljava/lang/String;)V
public synthetic fun <init> (Ljava/lang/String;JLjava/lang/String;Ljava/lang/String;Ljava/lang/Integer;Ljava/lang/Long;Ljava/util/List;Ljava/util/List;Ljava/lang/String;Ljava/lang/String;Ljava/lang/String;Ljava/lang/Long;Ljava/util/List;Ljava/lang/String;ILkotlin/jvm/internal/DefaultConstructorMarker;)V
public final fun component1 ()Ljava/lang/String;
public final fun component10 ()Ljava/lang/String;
public final fun component11 ()Ljava/lang/String;
Expand All @@ -75,8 +69,6 @@ public final class dev/sharingan/HttpEvent : dev/sharingan/SharinganEvent {
public final fun component7 ()Ljava/util/List;
public final fun component8 ()Ljava/util/List;
public final fun component9 ()Ljava/lang/String;
public final fun copy (Ljava/lang/String;JLjava/lang/String;Ljava/lang/String;Ljava/lang/Integer;Ljava/lang/Long;Ljava/util/List;Ljava/util/List;Ljava/lang/String;Ljava/lang/String;Ljava/lang/String;Ljava/lang/Long;Ljava/util/List;Ljava/lang/String;)Ldev/sharingan/HttpEvent;
public static synthetic fun copy$default (Ldev/sharingan/HttpEvent;Ljava/lang/String;JLjava/lang/String;Ljava/lang/String;Ljava/lang/Integer;Ljava/lang/Long;Ljava/util/List;Ljava/util/List;Ljava/lang/String;Ljava/lang/String;Ljava/lang/String;Ljava/lang/Long;Ljava/util/List;Ljava/lang/String;ILjava/lang/Object;)Ldev/sharingan/HttpEvent;
public fun equals (Ljava/lang/Object;)Z
public final fun getContentType ()Ljava/lang/String;
public final fun getDurationMillis ()Ljava/lang/Long;
Expand Down Expand Up @@ -122,8 +114,6 @@ public final class dev/sharingan/MqttDirection : java/lang/Enum {
}

public final class dev/sharingan/MqttEvent : dev/sharingan/SharinganEvent {
public fun <init> (Ljava/lang/String;JLdev/sharingan/MqttDirection;Ljava/lang/String;IZLjava/lang/String;Ljava/lang/Long;Ljava/lang/String;)V
public synthetic fun <init> (Ljava/lang/String;JLdev/sharingan/MqttDirection;Ljava/lang/String;IZLjava/lang/String;Ljava/lang/Long;Ljava/lang/String;ILkotlin/jvm/internal/DefaultConstructorMarker;)V
public final fun component1 ()Ljava/lang/String;
public final fun component2 ()J
public final fun component3 ()Ldev/sharingan/MqttDirection;
Expand All @@ -133,8 +123,6 @@ public final class dev/sharingan/MqttEvent : dev/sharingan/SharinganEvent {
public final fun component7 ()Ljava/lang/String;
public final fun component8 ()Ljava/lang/Long;
public final fun component9 ()Ljava/lang/String;
public final fun copy (Ljava/lang/String;JLdev/sharingan/MqttDirection;Ljava/lang/String;IZLjava/lang/String;Ljava/lang/Long;Ljava/lang/String;)Ldev/sharingan/MqttEvent;
public static synthetic fun copy$default (Ldev/sharingan/MqttEvent;Ljava/lang/String;JLdev/sharingan/MqttDirection;Ljava/lang/String;IZLjava/lang/String;Ljava/lang/Long;Ljava/lang/String;ILjava/lang/Object;)Ldev/sharingan/MqttEvent;
public fun equals (Ljava/lang/Object;)Z
public final fun getDirection ()Ldev/sharingan/MqttDirection;
public fun getError ()Ljava/lang/String;
Expand Down
9 changes: 0 additions & 9 deletions sharingan-noop/api/sharingan-noop.klib.api
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,8 +63,6 @@ final class dev.sharingan.ktor/SharinganKtorConfig { // dev.sharingan.ktor/Shari
}

final class dev.sharingan/BleEvent : dev.sharingan/SharinganEvent { // dev.sharingan/BleEvent|null[0]
constructor <init>(kotlin/String, kotlin/Long, dev.sharingan/BleOperation, kotlin/String, kotlin/String? = ..., kotlin/String? = ..., kotlin/String? = ..., kotlin/Long? = ..., kotlin/String? = ...) // dev.sharingan/BleEvent.<init>|<init>(kotlin.String;kotlin.Long;dev.sharingan.BleOperation;kotlin.String;kotlin.String?;kotlin.String?;kotlin.String?;kotlin.Long?;kotlin.String?){}[0]

final val characteristic // dev.sharingan/BleEvent.characteristic|{}characteristic[0]
final fun <get-characteristic>(): kotlin/String? // dev.sharingan/BleEvent.characteristic.<get-characteristic>|<get-characteristic>(){}[0]
final val device // dev.sharingan/BleEvent.device|{}device[0]
Expand Down Expand Up @@ -95,7 +93,6 @@ final class dev.sharingan/BleEvent : dev.sharingan/SharinganEvent { // dev.shari
final fun component7(): kotlin/String? // dev.sharingan/BleEvent.component7|component7(){}[0]
final fun component8(): kotlin/Long? // dev.sharingan/BleEvent.component8|component8(){}[0]
final fun component9(): kotlin/String? // dev.sharingan/BleEvent.component9|component9(){}[0]
final fun copy(kotlin/String = ..., kotlin/Long = ..., dev.sharingan/BleOperation = ..., kotlin/String = ..., kotlin/String? = ..., kotlin/String? = ..., kotlin/String? = ..., kotlin/Long? = ..., kotlin/String? = ...): dev.sharingan/BleEvent // dev.sharingan/BleEvent.copy|copy(kotlin.String;kotlin.Long;dev.sharingan.BleOperation;kotlin.String;kotlin.String?;kotlin.String?;kotlin.String?;kotlin.Long?;kotlin.String?){}[0]
final fun equals(kotlin/Any?): kotlin/Boolean // dev.sharingan/BleEvent.equals|equals(kotlin.Any?){}[0]
final fun hashCode(): kotlin/Int // dev.sharingan/BleEvent.hashCode|hashCode(){}[0]
final fun toString(): kotlin/String // dev.sharingan/BleEvent.toString|toString(){}[0]
Expand All @@ -114,8 +111,6 @@ final class dev.sharingan/BleLogger { // dev.sharingan/BleLogger|null[0]
}

final class dev.sharingan/HttpEvent : dev.sharingan/SharinganEvent { // dev.sharingan/HttpEvent|null[0]
constructor <init>(kotlin/String, kotlin/Long, kotlin/String, kotlin/String, kotlin/Int? = ..., kotlin/Long? = ..., kotlin.collections/List<kotlin/Pair<kotlin/String, kotlin/String>> = ..., kotlin.collections/List<kotlin/Pair<kotlin/String, kotlin/String>> = ..., kotlin/String? = ..., kotlin/String? = ..., kotlin/String? = ..., kotlin/Long? = ..., kotlin.collections/List<dev.sharingan/TimingPhase> = ..., kotlin/String? = ...) // dev.sharingan/HttpEvent.<init>|<init>(kotlin.String;kotlin.Long;kotlin.String;kotlin.String;kotlin.Int?;kotlin.Long?;kotlin.collections.List<kotlin.Pair<kotlin.String,kotlin.String>>;kotlin.collections.List<kotlin.Pair<kotlin.String,kotlin.String>>;kotlin.String?;kotlin.String?;kotlin.String?;kotlin.Long?;kotlin.collections.List<dev.sharingan.TimingPhase>;kotlin.String?){}[0]

final val contentType // dev.sharingan/HttpEvent.contentType|{}contentType[0]
final fun <get-contentType>(): kotlin/String? // dev.sharingan/HttpEvent.contentType.<get-contentType>|<get-contentType>(){}[0]
final val durationMillis // dev.sharingan/HttpEvent.durationMillis|{}durationMillis[0]
Expand Down Expand Up @@ -165,7 +160,6 @@ final class dev.sharingan/HttpEvent : dev.sharingan/SharinganEvent { // dev.shar
final fun component7(): kotlin.collections/List<kotlin/Pair<kotlin/String, kotlin/String>> // dev.sharingan/HttpEvent.component7|component7(){}[0]
final fun component8(): kotlin.collections/List<kotlin/Pair<kotlin/String, kotlin/String>> // dev.sharingan/HttpEvent.component8|component8(){}[0]
final fun component9(): kotlin/String? // dev.sharingan/HttpEvent.component9|component9(){}[0]
final fun copy(kotlin/String = ..., kotlin/Long = ..., kotlin/String = ..., kotlin/String = ..., kotlin/Int? = ..., kotlin/Long? = ..., kotlin.collections/List<kotlin/Pair<kotlin/String, kotlin/String>> = ..., kotlin.collections/List<kotlin/Pair<kotlin/String, kotlin/String>> = ..., kotlin/String? = ..., kotlin/String? = ..., kotlin/String? = ..., kotlin/Long? = ..., kotlin.collections/List<dev.sharingan/TimingPhase> = ..., kotlin/String? = ...): dev.sharingan/HttpEvent // dev.sharingan/HttpEvent.copy|copy(kotlin.String;kotlin.Long;kotlin.String;kotlin.String;kotlin.Int?;kotlin.Long?;kotlin.collections.List<kotlin.Pair<kotlin.String,kotlin.String>>;kotlin.collections.List<kotlin.Pair<kotlin.String,kotlin.String>>;kotlin.String?;kotlin.String?;kotlin.String?;kotlin.Long?;kotlin.collections.List<dev.sharingan.TimingPhase>;kotlin.String?){}[0]
final fun equals(kotlin/Any?): kotlin/Boolean // dev.sharingan/HttpEvent.equals|equals(kotlin.Any?){}[0]
final fun hashCode(): kotlin/Int // dev.sharingan/HttpEvent.hashCode|hashCode(){}[0]
final fun toString(): kotlin/String // dev.sharingan/HttpEvent.toString|toString(){}[0]
Expand All @@ -186,8 +180,6 @@ final class dev.sharingan/HttpLogger { // dev.sharingan/HttpLogger|null[0]
}

final class dev.sharingan/MqttEvent : dev.sharingan/SharinganEvent { // dev.sharingan/MqttEvent|null[0]
constructor <init>(kotlin/String, kotlin/Long, dev.sharingan/MqttDirection, kotlin/String, kotlin/Int = ..., kotlin/Boolean = ..., kotlin/String? = ..., kotlin/Long? = ..., kotlin/String? = ...) // dev.sharingan/MqttEvent.<init>|<init>(kotlin.String;kotlin.Long;dev.sharingan.MqttDirection;kotlin.String;kotlin.Int;kotlin.Boolean;kotlin.String?;kotlin.Long?;kotlin.String?){}[0]

final val direction // dev.sharingan/MqttEvent.direction|{}direction[0]
final fun <get-direction>(): dev.sharingan/MqttDirection // dev.sharingan/MqttEvent.direction.<get-direction>|<get-direction>(){}[0]
final val error // dev.sharingan/MqttEvent.error|{}error[0]
Expand Down Expand Up @@ -216,7 +208,6 @@ final class dev.sharingan/MqttEvent : dev.sharingan/SharinganEvent { // dev.shar
final fun component7(): kotlin/String? // dev.sharingan/MqttEvent.component7|component7(){}[0]
final fun component8(): kotlin/Long? // dev.sharingan/MqttEvent.component8|component8(){}[0]
final fun component9(): kotlin/String? // dev.sharingan/MqttEvent.component9|component9(){}[0]
final fun copy(kotlin/String = ..., kotlin/Long = ..., dev.sharingan/MqttDirection = ..., kotlin/String = ..., kotlin/Int = ..., kotlin/Boolean = ..., kotlin/String? = ..., kotlin/Long? = ..., kotlin/String? = ...): dev.sharingan/MqttEvent // dev.sharingan/MqttEvent.copy|copy(kotlin.String;kotlin.Long;dev.sharingan.MqttDirection;kotlin.String;kotlin.Int;kotlin.Boolean;kotlin.String?;kotlin.Long?;kotlin.String?){}[0]
final fun equals(kotlin/Any?): kotlin/Boolean // dev.sharingan/MqttEvent.equals|equals(kotlin.Any?){}[0]
final fun hashCode(): kotlin/Int // dev.sharingan/MqttEvent.hashCode|hashCode(){}[0]
final fun toString(): kotlin/String // dev.sharingan/MqttEvent.toString|toString(){}[0]
Expand Down
3 changes: 2 additions & 1 deletion sharingan-noop/src/commonMain/kotlin/BleEvent.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,8 @@ public enum class BleOperation {
* [payload] carries the decoded value as text — JSON is rendered with syntax
* colors in the detail screen, anything else is shown verbatim.
*/
public data class BleEvent(
@ConsistentCopyVisibility
public data class BleEvent internal constructor(
override val id: String,
override val timestampMillis: Long,
public val operation: BleOperation,
Expand Down
3 changes: 2 additions & 1 deletion sharingan-noop/src/commonMain/kotlin/HttpEvent.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,8 @@ public data class TimingPhase(
* rows read like an access log. A `null` [statusCode] together with a non-null
* [error] means the request failed at the transport layer.
*/
public data class HttpEvent(
@ConsistentCopyVisibility
public data class HttpEvent internal constructor(
override val id: String,
override val timestampMillis: Long,
public val method: String,
Expand Down
3 changes: 2 additions & 1 deletion sharingan-noop/src/commonMain/kotlin/MqttEvent.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,8 @@ public enum class MqttDirection {
* For [MqttDirection.SUBSCRIBE] events, [topic] holds the topic *filter*
* (it may contain `+`/`#` wildcards) and [payload] is `null`.
*/
public data class MqttEvent(
@ConsistentCopyVisibility
public data class MqttEvent internal constructor(
override val id: String,
override val timestampMillis: Long,
public val direction: MqttDirection,
Expand Down
12 changes: 0 additions & 12 deletions sharingan/api/sharingan.api
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
public final class dev/sharingan/BleEvent : dev/sharingan/SharinganEvent {
public static final field $stable I
public fun <init> (Ljava/lang/String;JLdev/sharingan/BleOperation;Ljava/lang/String;Ljava/lang/String;Ljava/lang/String;Ljava/lang/String;Ljava/lang/Long;Ljava/lang/String;)V
public synthetic fun <init> (Ljava/lang/String;JLdev/sharingan/BleOperation;Ljava/lang/String;Ljava/lang/String;Ljava/lang/String;Ljava/lang/String;Ljava/lang/Long;Ljava/lang/String;ILkotlin/jvm/internal/DefaultConstructorMarker;)V
public final fun component1 ()Ljava/lang/String;
public final fun component2 ()J
public final fun component3 ()Ldev/sharingan/BleOperation;
Expand All @@ -11,8 +9,6 @@ public final class dev/sharingan/BleEvent : dev/sharingan/SharinganEvent {
public final fun component7 ()Ljava/lang/String;
public final fun component8 ()Ljava/lang/Long;
public final fun component9 ()Ljava/lang/String;
public final fun copy (Ljava/lang/String;JLdev/sharingan/BleOperation;Ljava/lang/String;Ljava/lang/String;Ljava/lang/String;Ljava/lang/String;Ljava/lang/Long;Ljava/lang/String;)Ldev/sharingan/BleEvent;
public static synthetic fun copy$default (Ldev/sharingan/BleEvent;Ljava/lang/String;JLdev/sharingan/BleOperation;Ljava/lang/String;Ljava/lang/String;Ljava/lang/String;Ljava/lang/String;Ljava/lang/Long;Ljava/lang/String;ILjava/lang/Object;)Ldev/sharingan/BleEvent;
public fun equals (Ljava/lang/Object;)Z
public final fun getCharacteristic ()Ljava/lang/String;
public final fun getDevice ()Ljava/lang/String;
Expand Down Expand Up @@ -68,8 +64,6 @@ public final class dev/sharingan/ComposableSingletons$SharinganActivityKt {

public final class dev/sharingan/HttpEvent : dev/sharingan/SharinganEvent {
public static final field $stable I
public fun <init> (Ljava/lang/String;JLjava/lang/String;Ljava/lang/String;Ljava/lang/Integer;Ljava/lang/Long;Ljava/util/List;Ljava/util/List;Ljava/lang/String;Ljava/lang/String;Ljava/lang/String;Ljava/lang/Long;Ljava/util/List;Ljava/lang/String;)V
public synthetic fun <init> (Ljava/lang/String;JLjava/lang/String;Ljava/lang/String;Ljava/lang/Integer;Ljava/lang/Long;Ljava/util/List;Ljava/util/List;Ljava/lang/String;Ljava/lang/String;Ljava/lang/String;Ljava/lang/Long;Ljava/util/List;Ljava/lang/String;ILkotlin/jvm/internal/DefaultConstructorMarker;)V
public final fun component1 ()Ljava/lang/String;
public final fun component10 ()Ljava/lang/String;
public final fun component11 ()Ljava/lang/String;
Expand All @@ -84,8 +78,6 @@ public final class dev/sharingan/HttpEvent : dev/sharingan/SharinganEvent {
public final fun component7 ()Ljava/util/List;
public final fun component8 ()Ljava/util/List;
public final fun component9 ()Ljava/lang/String;
public final fun copy (Ljava/lang/String;JLjava/lang/String;Ljava/lang/String;Ljava/lang/Integer;Ljava/lang/Long;Ljava/util/List;Ljava/util/List;Ljava/lang/String;Ljava/lang/String;Ljava/lang/String;Ljava/lang/Long;Ljava/util/List;Ljava/lang/String;)Ldev/sharingan/HttpEvent;
public static synthetic fun copy$default (Ldev/sharingan/HttpEvent;Ljava/lang/String;JLjava/lang/String;Ljava/lang/String;Ljava/lang/Integer;Ljava/lang/Long;Ljava/util/List;Ljava/util/List;Ljava/lang/String;Ljava/lang/String;Ljava/lang/String;Ljava/lang/Long;Ljava/util/List;Ljava/lang/String;ILjava/lang/Object;)Ldev/sharingan/HttpEvent;
public fun equals (Ljava/lang/Object;)Z
public final fun getContentType ()Ljava/lang/String;
public final fun getDurationMillis ()Ljava/lang/Long;
Expand Down Expand Up @@ -133,8 +125,6 @@ public final class dev/sharingan/MqttDirection : java/lang/Enum {

public final class dev/sharingan/MqttEvent : dev/sharingan/SharinganEvent {
public static final field $stable I
public fun <init> (Ljava/lang/String;JLdev/sharingan/MqttDirection;Ljava/lang/String;IZLjava/lang/String;Ljava/lang/Long;Ljava/lang/String;)V
public synthetic fun <init> (Ljava/lang/String;JLdev/sharingan/MqttDirection;Ljava/lang/String;IZLjava/lang/String;Ljava/lang/Long;Ljava/lang/String;ILkotlin/jvm/internal/DefaultConstructorMarker;)V
public final fun component1 ()Ljava/lang/String;
public final fun component2 ()J
public final fun component3 ()Ldev/sharingan/MqttDirection;
Expand All @@ -144,8 +134,6 @@ public final class dev/sharingan/MqttEvent : dev/sharingan/SharinganEvent {
public final fun component7 ()Ljava/lang/String;
public final fun component8 ()Ljava/lang/Long;
public final fun component9 ()Ljava/lang/String;
public final fun copy (Ljava/lang/String;JLdev/sharingan/MqttDirection;Ljava/lang/String;IZLjava/lang/String;Ljava/lang/Long;Ljava/lang/String;)Ldev/sharingan/MqttEvent;
public static synthetic fun copy$default (Ldev/sharingan/MqttEvent;Ljava/lang/String;JLdev/sharingan/MqttDirection;Ljava/lang/String;IZLjava/lang/String;Ljava/lang/Long;Ljava/lang/String;ILjava/lang/Object;)Ldev/sharingan/MqttEvent;
public fun equals (Ljava/lang/Object;)Z
public final fun getDirection ()Ldev/sharingan/MqttDirection;
public fun getError ()Ljava/lang/String;
Expand Down
Loading
Loading