test: cover core analysis services through the DbDriver seam#2
Merged
Conversation
Adds direct tests for the four analysis services that carry the product's value and are now reachable via the in-memory adapter: - coverage-2d: Pillar×Function cell placement + the three unplaced buckets (no keyword tag / no section tag / outside sections); empty + undeclared- lens paths. - track: year bucketing, year-unknown bucket, match-count / coverage-percent / score measures, group none/polarity/company, single-keyword topic. - compare: match-count / distinct-keywords / pos-minus-counter / score metrics, ranking order, keyword narrowing, company filter, excluded count. - gap: substance/tone/gap per level + over-time aggregation, with api.analyzeSentimentBatch mocked; single-document flag; tone cache reuse. 63 tests total (was 44). Typecheck, lint clean. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds on the architecture-deepening work (#1) by adding direct tests for the four core analysis services, now reachable via the in-memory
DbDriveradapter.Coverage added (+19 tests → 63 total)
api.analyzeSentimentBatchmocked), single-document flag, tone-cache reuse.Notes
🤖 Generated with Claude Code