Paintable posters#303
Open
Piggy3 wants to merge 1 commit into
Open
Conversation
New entity: blank poster Added "paintable" component to PosterBase Currently, does not work. "Painting" uses the charge, but seemingly has no effect. The ftl file needs lots of tedious work. I can do that when the core mechanic painting are good to go
github-actions
Bot
added
S: Needs Review
S: Untriaged
size/S
Changes: No C#
and removed
S: Untriaged
size/S
labels
Collaborator
|
The spray painter doesn't seem to currently update any poster sprites properly. Also we still need a way to make new posters (and ideally a better way to remove them). Overall good work, just needs some tuning. Was also getting this message in debug: [DEBG] system.user_interface: UI Key got BoundInterfaceMessageWrapMessage from a client who was not subscribed: Jason Woodworth (8/n6650, MobHuman, localhost@Zetaplx) but I can't see any code in your changes that would cause that. Perhaps consider rebasing to current persistent_testing before further changes if you decide to keep adding to this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About the PR
New entity: blank poster. Letting people paint over posters
Why / Balance
Technical details
Added "paintable" component to PosterBase
Currently, "painting" uses the charge, but seemingly has no effect.
The ftl file needs lots of tedious work. I can do that when the core mechanic painting are good to go
Media
Requirements
Breaking changes
Changelog