Skip to content

Conversation

@eddiem-git
Copy link
Collaborator

No description provided.

@Git-Leon
Copy link

Git-Leon commented Dec 13, 2019

The packaging of your application is incorrect.
Consider this... To inspect your application, I would like to see what end points are available in the application. With your current package structure, it requires a great deal of effort.
Typically, we have a controller package for this reason. The controller package allows us to see all of the ways a client can potentially speak to the application.

Again, I strongly advise that you revise the package structure.
It will:
1. Not scale elegantly
2. Not be easy for other developers to understand how to speak to the application.
3. Be unconventional
4. Appear to be novice explorations rather than professional or expert references.

@Git-Leon
Copy link

There is a reason we have design patterns.

@Git-Leon
Copy link

What is the purpose of the voting system in the chat?
@mikescho1 @michkin32 @eddiem-git @Kievina

@mikescho1
Copy link

The packaging of your application is incorrect.
Consider this... To inspect your application, I would like to see what end points are available in the application. With your current package structure, it requires a great deal of effort.
Typically, we have a controller package for this reason. The controller package allows us to see all of the ways a client can potentially speak to the application.

Again, I strongly advise that you revise the package structure.
It will:

  1. Not scale elegantly
  2. Not be easy for other developers to understand how to speak to the application.
  3. Be unconventional
  4. Appear to be novice explorations rather than professional or expert references.

We have a controller, service, entity, and repository class for each main feature. How would you change it?

@mikescho1
Copy link

What is the purpose of the voting system in the chat?
@mikescho1 @michkin32 @eddiem-git @Kievina

We have a feature to allow users to created polls. The votes are for the various options in a poll

@mikescho1
Copy link

There is a reason we have design patterns.

As far as we know, we are using the MVC pattern. Please let us know if this is not the case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants