Port to 1.21.1#17
Conversation
| public void setPosition(int x, int y) { | ||
| this.x = x; | ||
| this.y = y; | ||
| realX = x; | ||
| realY = y; | ||
| } | ||
|
|
There was a problem hiding this comment.
Needed for workbench UI, otherwise material slots are wrongly positioned. Could remove the unused realX and realY however, I will do that.
| @Override | ||
| public boolean mayPlace(@Nullable ItemStack stack) { | ||
| return isEnabled; | ||
| return isEnabled && super.mayPlace(stack == null ? ItemStack.EMPTY : stack); |
There was a problem hiding this comment.
Shouldn't this pass the itemstack as is to the parent method?
There was a problem hiding this comment.
Super does not accept nullable, but you're right, all callers are non-nullable so it can be removed along with the @nullable annotation.
| @@ -1 +1,2 @@ | |||
| public net.minecraft.client.gui.GuiGraphics m_280479_(Lnet/minecraft/resources/ResourceLocation;IIIIIFFFFFFFF)V # innerBlit No newline at end of file | |||
| public-f net.minecraft.world.inventory.Slot x | |||
| public-f net.minecraft.world.inventory.Slot y | |||
There was a problem hiding this comment.
This can be removed if ToggleableSlot.setPosition isn't needed
| forge*changelog.txt | ||
|
|
||
| # local publishing output | ||
| /repo/ |
There was a problem hiding this comment.
What's going on here? Were there changes to artifact name and locations in 1.21?
There was a problem hiding this comment.
It's standard from the neoforge 1.21 mdk template -- neoforge uses "runs" rather than "run" and "repo" for local output.
| @@ -1,134 +1,133 @@ | |||
| plugins { | |||
| id 'eclipse' | |||
There was a problem hiding this comment.
Is this based on the boilerplate mod for neo 1.21.1 or is it just vibes?
There was a problem hiding this comment.
It's almost entirely identical to the neoforge 1.21 mdk template
|
please use MDG evelant#1 |
3 participants
Ported to 1.21.1 to make Tetra 1.21.1 port work, should probably be a new branch but github won't allow a PR against a branch that doesn't exist yet. See mickelus/tetra#931