Skip to content

Multithread improvements (backport #205)#206

Merged
pablogs9 merged 2 commits into
foxyfrom
mergify/bp/foxy/pr-205
Nov 25, 2021
Merged

Multithread improvements (backport #205)#206
pablogs9 merged 2 commits into
foxyfrom
mergify/bp/foxy/pr-205

Conversation

@mergify
Copy link
Copy Markdown
Contributor

@mergify mergify Bot commented Nov 25, 2021

This is an automatic backport of pull request #205 done by Mergify.
Cherry-pick of 5de3d76 has failed:

On branch mergify/bp/foxy/pr-205
Your branch is up to date with 'origin/foxy'.

You are currently cherry-picking commit 5de3d76.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   rmw_microxrcedds_c/include/rmw_microros/ping.h
	modified:   rmw_microxrcedds_c/src/callbacks.c
	modified:   rmw_microxrcedds_c/src/rmw_init.c
	modified:   rmw_microxrcedds_c/src/rmw_microros/ping.c
	modified:   rmw_microxrcedds_c/src/rmw_microros_internal/memory.h
	modified:   rmw_microxrcedds_c/src/rmw_microros_internal/types.h
	modified:   rmw_microxrcedds_c/src/rmw_request.c
	modified:   rmw_microxrcedds_c/src/rmw_response.c
	modified:   rmw_microxrcedds_c/src/rmw_take.c
	modified:   rmw_microxrcedds_c/src/rmw_wait.c
	modified:   rmw_microxrcedds_c/src/types.c

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   .github/workflows/ci.yml

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

* Minor fixes

* Add rmw_wait mutex

* Protect static_buffer_memory access

* Use new ping API

* Update ci.yml

* Fix

* Fix linter

* Apply suggestions from code review

Co-authored-by: Antonio Cuadros <49162117+Acuadros95@users.noreply.github.com>

* Fix

* Delete old unlock mutex

* Update .github/workflows/ci.yml

Co-authored-by: Antonio Cuadros <49162117+Acuadros95@users.noreply.github.com>
Co-authored-by: Antonio Cuadros <acuadros1995@gmail.com>
(cherry picked from commit 5de3d76)

# Conflicts:
#	.github/workflows/ci.yml
@mergify mergify Bot added the conflicts label Nov 25, 2021
@mergify mergify Bot mentioned this pull request Nov 25, 2021
Signed-off-by: Pablo Garrido <pablogs9@gmail.com>
@github-actions
Copy link
Copy Markdown

Static memory analysis

Default configuration

MTU: 512 B
Input buffer size: 2048 B
Input history: 4
Output buffer size: 2048 B
Output history: 4

Entity Qty Size per unit
Context 2 5616 B
Topic 8 56 B
Service 4 248 B
Client 4 248 B
Subscription 4 272 B
Publisher 4 280 B
Node 4 208 B
Static input buffer 8 2136 B
Init options 6 64 B
Wait sets 4 56 B
Guard Condition 4 64 B

TOTAL: 34436 B

@pablogs9 pablogs9 merged commit 4d17bee into foxy Nov 25, 2021
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

Merging #206 (a5c0114) into foxy (1155805) will increase coverage by 0.02%.
The diff coverage is 93.75%.

Impacted file tree graph

@@            Coverage Diff             @@
##             foxy     #206      +/-   ##
==========================================
+ Coverage   47.85%   47.88%   +0.02%     
==========================================
  Files          40       40              
  Lines        1678     1675       -3     
  Branches      333      333              
==========================================
- Hits          803      802       -1     
+ Misses        665      662       -3     
- Partials      210      211       +1     
Impacted Files Coverage Δ
rmw_microxrcedds_c/src/rmw_init.c 58.78% <ø> (ø)
rmw_microxrcedds_c/src/rmw_request.c 69.81% <ø> (ø)
rmw_microxrcedds_c/src/rmw_response.c 69.23% <ø> (ø)
rmw_microxrcedds_c/src/rmw_take.c 26.00% <ø> (ø)
rmw_microxrcedds_c/src/rmw_wait.c 73.01% <ø> (ø)
rmw_microxrcedds_c/src/types.c 64.66% <ø> (ø)
rmw_microxrcedds_c/src/rmw_microros/ping.c 45.45% <50.00%> (-4.55%) ⬇️
rmw_microxrcedds_c/src/callbacks.c 67.21% <100.00%> (+3.15%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1155805...a5c0114. Read the comment docs.

@pablogs9 pablogs9 deleted the mergify/bp/foxy/pr-205 branch November 25, 2021 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants