-
Notifications
You must be signed in to change notification settings - Fork 6
[Fix #58] Sync Latest Code and Update GitHub Actions #57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update index.adoc
Uploading Mindmap image for MicroProfile Architecture Philosophy
Adding content for Chapter01 - Introduction to MicroProfile
Incorporating feedbacks about MicroProfile History from @aeiras
Updating MPWG members
Need for MicroProfile
MicroProfile Platform Component Specifications
Standalone (Outside Umbrella) Specifications
Standalone (Outside Umbrella) Specifications
MicroProfile Implementations
Architecture Philosophy
Relationship with Jakarta EE specification
Incorportating suggestions from microprofile#5
Co-authored-by: Emily Jiang <emijiang6@googlemail.com>
Co-authored-by: Emily Jiang <emijiang6@googlemail.com>
Build Tools
Setting up your IDE - part 1
Setting up MicroProfile Runtime
MicroProfile Starter
feat: enhance PDF generation and download handling with timestamps
feat: clean previous build directory and enhance PDF generation verif…
…generation configuration
…lity - Updated the <lastmod> timestamps for all URLs in sitemap.xml to reflect the latest modification date. - Added a script in head-meta.hbs to force PDF links to download instead of opening in the browser, enhancing user experience.
- Updated .htaccess to set proper MIME type for PDF files and ensure correct serving. - Modified .gitignore to include Antora build output directory. - Adjusted PDF metadata for creation and modification dates. - Updated 404.html and README.html to ensure PDF links point to the correct absolute path and include download attributes. - Refactored JavaScript in multiple chapter HTML files to ensure PDF links are correctly configured for downloading. - Updated sitemap.xml with new last modified dates for all pages. - Updated head-meta.hbs to ensure PDF links are correctly configured for downloading.
…that cause timeouts" This reverts commit 346e2cf.
ttelang
commented
Aug 26, 2025
Member
|
There are many files in this PR and some commits from last year. Can you tidy up this PR @ttelang as it is still marked as draft? |
ttelang
commented
Sep 15, 2025
Contributor
Author
ttelang
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changing to Final review from Draft stage.
Fix for microprofile#58 Update build-and-deploy-tutorial.yml to execute the upate-repo-url.sh so that we get the correct edit URL in the generated HTML files.
Emily-Jiang
approved these changes
Sep 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #58
This pull request contains the following changes:
The following are the changes in details:
Removed unused font files
Removing unused workflow files
.github/workflows/
- antora.yml: Removed legacy Antora workflow for site generation.
- pages-antora.yml: Removed duplicate workflow for Antora-based GitHub Pages deployment.
- pages-static.yml: Removed old workflow for deploying static content.
- static.yml: Removed outdated static site deployment workflow.
.gitignore: Added Antora build output directory to ignored files.
README.adoc:
expanded Antora and GitHub Actions documentation, clarified build instructions, workflow details.
antora-assembler.yml:
Updated Antora site and PDF output configuration, changed content source URL, added comments for extension settings.
antora.yml:
Enhanced Antora component metadata with comments
Updating the build assets to latest (initially used for testing and to be used as default assets in case workflow fails to generate them for any reason). This entire build folder can be added to .gitignore going forward.